Token: simplified hasKnownIntValue()

Author: firewave

lib/token.cpp

@@ -2490,13 +2490,15 @@ std::shared_ptr<ScopeInfo2> Token::scopeInfo() const
     return mImpl->mScopeInfo;
 }
 
+// if there is a known INT value it will always be the first entry
 bool Token::hasKnownIntValue() const
 {
     if (!mImpl->mValues)
         return false;
-    return std::any_of(mImpl->mValues->begin(), mImpl->mValues->end(), [](const ValueFlow::Value& value) {
-        return value.isKnown() && value.isIntValue();
-    });
+    if (mImpl->mValues->empty())
+        return false;
+    const ValueFlow::Value& value = mImpl->mValues->front();
+    return value.isIntValue() && value.isKnown();
 }
 
 bool Token::hasKnownValue() const

lib/token.h

@@ -1307,7 +1307,6 @@ class CPPCHECKLIB Token {
     const ValueFlow::Value* getKnownValue() const;
     const ValueFlow::Value* getKnownValue(ValueFlow::Value::ValueType t) const;
     MathLib::bigint getKnownIntValue() const {
-        // TODO: need to perform lookup
         assert(!mImpl->mValues->empty());
         assert(mImpl->mValues->front().isKnown());
         assert(mImpl->mValues->front().valueType == ValueFlow::Value::ValueType::INT);