fixed #13719 - fixed nullptr dereference in Library::detectSmartPointer() (#7379)

Author: firewave

lib/library.cpp

@@ -1892,6 +1892,8 @@ bool Library::isSmartPointer(const Token* tok) const
 
 const Library::SmartPointer* Library::detectSmartPointer(const Token* tok, bool withoutStd) const
 {
+    if (!tok)
+        return nullptr;
     std::string typestr = withoutStd ? "std::" : "";
     if (tok->str() == "::")
         tok = tok->next();

test/testlibrary.cpp

@@ -69,6 +69,7 @@ class TestLibrary : public TestFixture {
         TEST_CASE(version);
         TEST_CASE(loadLibErrors);
         TEST_CASE(loadLibCombinations);
+        TEST_CASE(smartpointer);
     }
 
     void isCompliantValidationExpression() const {
@@ -868,6 +869,8 @@ class TestLibrary : public TestFixture {
         ASSERT_EQUALS(F.endPattern, "");
         ASSERT_EQUALS(F.itEndPattern, ":: iterator");
 
+        ASSERT(!library.detectContainerOrIterator(nullptr));
+
         {
             const SimpleTokenizer var(*this, "std::A<int> a;");
             ASSERT_EQUALS(&A, library.detectContainer(var.tokens()));
@@ -1140,6 +1143,15 @@ class TestLibrary : public TestFixture {
             ASSERT_EQUALS(s.library.defines().empty(), false);
         }
     }
+
+    void smartpointer() const {
+        const Settings s = settingsBuilder().library("std.cfg").build();
+        const Library& library = s.library;
+
+        ASSERT(!library.detectSmartPointer(nullptr));
+
+        // TODO: add more tests
+    }
 };
 
 REGISTER_TEST(TestLibrary)

test/testsymboldatabase.cpp

@@ -612,6 +612,8 @@ class TestSymbolDatabase : public TestFixture {
         TEST_CASE(testValuetypeOriginalName);
 
         TEST_CASE(dumpFriend); // Check if isFriend added to dump file
+
+        TEST_CASE(smartPointerLookupCtor); // #13719);
     }
 
     void array() {
@@ -11190,6 +11192,14 @@ class TestSymbolDatabase : public TestFixture {
         db->printXml(ostr);
         ASSERT(ostr.str().find(" isFriend=\"true\"") != std::string::npos);
     }
+
+    void smartPointerLookupCtor() { // #13719
+        // do not crash in smartpointer lookup
+        GET_SYMBOL_DB("struct S { int v; S(int i); };\n"
+                      "void f() { S(0).v; }");
+
+        ASSERT(db);
+    }
 };
 
 REGISTER_TEST(TestSymbolDatabase)