Skip to content

Commit 4290963

Browse files
committed
transfer back all inline suppressions from projects
1 parent dbcd363 commit 4290963

File tree

2 files changed

+2
-23
lines changed

2 files changed

+2
-23
lines changed

lib/cppcheck.cpp

+2-4
Original file line numberDiff line numberDiff line change
@@ -810,11 +810,9 @@ unsigned int CppCheck::check(const FileSettings &fs)
810810
const unsigned int returnValue = temp.checkFile(fs.file, fs.cfg);
811811
for (const auto& suppr : temp.mSettings.supprs.nomsg.getSuppressions())
812812
{
813-
// skip inline suppressions - are handled in checkFile()
814813
if (suppr.isInline) {
815-
// need to transfer unusedFunction suppressions because these are handled later on
816-
if (suppr.errorId == "unusedFunction")
817-
mSettings.supprs.nomsg.addSuppression(suppr); // TODO: check result
814+
// need to transfer all inline suppressions because these are used later on
815+
mSettings.supprs.nomsg.addSuppression(suppr); // TODO: check result
818816
continue;
819817
}
820818

test/cli/whole-program_test.py

-19
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@ def test_addon_suppress_inline():
5353
__test_addon_suppress_inline(['-j1'])
5454

5555

56-
# TODO: inline suppressions currently do not work with whole program analysis and addons - see #12835
57-
# whole program analysis requires a build dir with -j
58-
@pytest.mark.xfail(strict=True)
5956
def test_addon_suppress_inline_j():
6057
__test_addon_suppress_inline(['-j2'])
6158

@@ -66,8 +63,6 @@ def test_addon_suppress_inline_builddir(tmpdir):
6663
__test_addon_suppress_inline(['-j1', '--cppcheck-build-dir={}'.format(build_dir)])
6764

6865

69-
# TODO: inline suppressions currently do not work with whole program analysis and addons - see #12835
70-
@pytest.mark.xfail(strict=True)
7166
def test_addon_suppress_inline_builddir_j(tmpdir):
7267
build_dir = os.path.join(tmpdir, 'b1')
7368
os.mkdir(build_dir)
@@ -101,9 +96,6 @@ def test_addon_suppress_inline_project(tmpdir):
10196
__test_addon_suppress_inline_project(tmpdir, ['-j1'])
10297

10398

104-
# TODO: inline suppressions currently do not work with whole program analysis and addons - see #12835
105-
# whole program analysis requires a build dir with -j
106-
@pytest.mark.xfail(strict=True)
10799
def test_addon_suppress_inline_project_j(tmpdir):
108100
__test_addon_suppress_inline_project(tmpdir, ['-j2'])
109101

@@ -114,8 +106,6 @@ def test_addon_suppress_inline_project_builddir(tmpdir):
114106
__test_addon_suppress_inline_project(tmpdir, ['-j1', '--cppcheck-build-dir={}'.format(build_dir)])
115107

116108

117-
# TODO: inline suppressions currently do not work with whole program analysis and addons - see #12835
118-
@pytest.mark.xfail(strict=True)
119109
def test_addon_suppress_inline_project_builddir_j(tmpdir):
120110
build_dir = os.path.join(tmpdir, 'b1')
121111
os.mkdir(build_dir)
@@ -146,9 +136,6 @@ def test_suppress_inline():
146136
__test_suppress_inline(['-j1'])
147137

148138

149-
# TODO: inline suppressions do not work with whole program analysis and -j
150-
# whole program analysis requires a build dir with -j
151-
@pytest.mark.xfail(strict=True)
152139
def test_suppress_inline_j():
153140
__test_suppress_inline(['-j2'])
154141

@@ -159,8 +146,6 @@ def test_suppress_inline_builddir(tmpdir):
159146
__test_suppress_inline(['-j1', '--cppcheck-build-dir={}'.format(build_dir)])
160147

161148

162-
# TODO: inline suppressions do not work with whole program analysis and -j
163-
@pytest.mark.xfail(strict=True)
164149
def test_suppress_inline_builddir_j(tmpdir):
165150
build_dir = os.path.join(tmpdir, 'b1')
166151
os.mkdir(build_dir)
@@ -195,8 +180,6 @@ def test_suppress_inline_project(tmpdir):
195180
__test_suppress_inline_project(tmpdir, ['-j1'])
196181

197182

198-
# whole program analysis requires a build dir with -j
199-
@pytest.mark.xfail(strict=True)
200183
def test_suppress_inline_project_j(tmpdir):
201184
__test_suppress_inline_project(tmpdir, ['-j2'])
202185

@@ -206,8 +189,6 @@ def test_suppress_inline_project_builddir(tmpdir):
206189
os.mkdir(build_dir)
207190
__test_suppress_inline_project(tmpdir, ['-j1', '--cppcheck-build-dir={}'.format(build_dir)])
208191

209-
# TODO: inline suppressions do not work with whole program analysis and -j
210-
@pytest.mark.xfail(strict=True)
211192
def test_suppress_inline_project_builddir_j(tmpdir):
212193
build_dir = os.path.join(tmpdir, 'b1')
213194
os.mkdir(build_dir)

0 commit comments

Comments
 (0)