added test to make sure samples produce the expected output / adjusted samples output and small cleanup (#6180)

Author: firewave

samples/arrayIndexOutOfBounds/out.txt

@@ -0,0 +1,3 @@
+samples\arrayIndexOutOfBounds_1\bad.c:7:6: error: Array 'a[2]' accessed at index 2, which is out of bounds. [arrayIndexOutOfBounds]
+    a[2] = 0;
+     ^

samples/arrayIndexOutOfBounds/bad.c renamed to samples/arrayIndexOutOfBounds_1/bad.c

@@ -0,0 +1,8 @@
+int main()
+{
+    int a[2];
+    int i;
+    for (i = 0; i < 3; i++)
+        a[i] = 0;
+    return a[0];
+}

samples/arrayIndexOutOfBounds/good.c renamed to samples/arrayIndexOutOfBounds_1/good.c

@@ -0,0 +1,8 @@
+int main()
+{
+    int a[3];
+    int i;
+    for (i = 0; i < 3; i++)
+        a[i] = 0;
+    return a[0];
+}

samples/arrayIndexOutOfBounds_1/out.txt

@@ -0,0 +1,9 @@
+samples\arrayIndexOutOfBounds_2\bad.c:6:10: error: Array 'a[2]' accessed at index 2, which is out of bounds. [arrayIndexOutOfBounds]
+        a[i] = 0;
+         ^
+samples\arrayIndexOutOfBounds_2\bad.c:5:19: note: Assuming that condition 'i<3' is not redundant
+    for (i = 0; i < 3; i++)
+                  ^
+samples\arrayIndexOutOfBounds_2\bad.c:6:10: note: Array index out of bounds
+        a[i] = 0;
+         ^

samples/arrayIndexOutOfBounds_2/bad.c

@@ -1,8 +1,7 @@
+#include <stdio.h>
 int main()
 {
-    int a[2];
-    int i;
-    for (i = 0; i < 3; i++)
-        a[i] = 0;
-    return a[0];
+    char str[5];
+    strcpy(str, "0123456789abcdef");
+    return 0;
 }

samples/arrayIndexOutOfBounds_2/good.c

@@ -1,8 +1,7 @@
+#include <stdio.h>
 int main()
 {
-    int a[3];
-    int i;
-    for (i = 0; i < 3; i++)
-        a[i] = 0;
-    return a[0];
+    char str[10];
+    snprintf(str, 10, "%s", "abc");
+    return 0;
 }

samples/arrayIndexOutOfBounds_2/out.txt

@@ -1,3 +1,3 @@
-samples\bufferAccessOutOfBounds\bad.c:6:10: error: Array 'a[2]' accessed at index 2, which is out of bounds. [arrayIndexOutOfBounds]
-        a[i] = 0;
-         ^
+samples\bufferAccessOutOfBounds\bad.c:5:12: error: Buffer is accessed out of bounds: str [bufferAccessOutOfBounds]
+    strcpy(str, "0123456789abcdef");
+           ^