valueflow-fast: Added a --check-level=fast option.

Author: danmar

cli/cmdlineparser.cpp

@@ -475,7 +475,9 @@ CmdLineParser::Result CmdLineParser::parseFromArgs(int argc, const char* const a
             else if (std::strncmp(argv[i], "--check-level=", 14) == 0) {
                 Settings::CheckLevel level = Settings::CheckLevel::normal;
                 const std::string level_s(argv[i] + 14);
-                if (level_s == "normal")
+                if (level_s == "fast")
+                    level = Settings::CheckLevel::fast;
+                else if (level_s == "normal")
                     level = Settings::CheckLevel::normal;
                 else if (level_s == "exhaustive")
                     level = Settings::CheckLevel::exhaustive;
@@ -1471,8 +1473,11 @@ void CmdLineParser::printHelp() const
         "    --check-config       Check cppcheck configuration. The normal code\n"
         "                         analysis is disabled by this flag.\n"
         "    --check-level=<level>\n"
-        "                         Configure how much checking you want:\n"
-        "                          * normal: Cppcheck uses some compromises in the checking so\n"
+        "                         Configure how much valueflow analysis you want:\n"
+        "                          * fast: All checkers are executed however the valueflow is\n"
+        "                            limited. Our goal is to perform as much valueflow analysis as\n"
+        "                            we can however it should take less time than parsing the file.\n"
+        "                          * normal: Cppcheck uses some compromises in the analysis so\n"
         "                            the checking will finish in reasonable time.\n"
         "                          * exhaustive: deeper analysis that you choose when you can\n"
         "                            wait.\n"

lib/settings.cpp

@@ -287,7 +287,16 @@ void Settings::loadSummaries()
 
 void Settings::setCheckLevel(CheckLevel level)
 {
-    if (level == CheckLevel::normal) {
+    if (level == CheckLevel::fast) {
+        // Checking should finish quickly.
+        checkLevel = level;
+        vfOptions.maxSubFunctionArgs = 8;
+        vfOptions.maxIfCount = 100;
+        vfOptions.doConditionExpressionAnalysis = false;
+        vfOptions.maxForwardBranches = 4;
+        vfOptions.maxIterations = 1;
+    }
+    else if (level == CheckLevel::normal) {
         // Checking should finish in reasonable time.
         checkLevel = level;
         vfOptions.maxSubFunctionArgs = 8;

lib/settings.h

@@ -487,6 +487,7 @@ class CPPCHECKLIB WARN_UNUSED Settings {
     }
 
     enum class CheckLevel {
+        fast,
         normal,
         exhaustive
     };

lib/valueflow.cpp

@@ -8592,9 +8592,9 @@ static ValueFlowPassAdaptor<F> makeValueFlowPassAdaptor(const char* name, bool c
     return {name, cpp, run};
 }
 
-#define VALUEFLOW_ADAPTOR(cpp, ...)                                                                                    \
+#define VALUEFLOW_ADAPTOR(cpp, slow, ...)                                                                              \
     makeValueFlowPassAdaptor(#__VA_ARGS__,                                                                             \
-                             (cpp),                                                                                      \
+                             (cpp),                                                                                    \
                              [](TokenList& tokenlist,                                                                  \
                                 SymbolDatabase& symboldatabase,                                                        \
                                 ErrorLogger& errorLogger,                                                              \
@@ -8603,13 +8603,14 @@ static ValueFlowPassAdaptor<F> makeValueFlowPassAdaptor(const char* name, bool c
         (void)tokenlist;                                                                      \
         (void)symboldatabase;                                                                 \
         (void)errorLogger;                                                                    \
-        (void)settings;                                                                       \
         (void)skippedFunctions;                                                               \
-        __VA_ARGS__;                                                                          \
+        if (!(slow) || settings.checkLevel >= Settings::CheckLevel::normal)                     \
+            __VA_ARGS__;                                                                      \
     })
 
-#define VFA(...) VALUEFLOW_ADAPTOR(false, __VA_ARGS__)
-#define VFA_CPP(...) VALUEFLOW_ADAPTOR(true, __VA_ARGS__)
+#define VFA(...) VALUEFLOW_ADAPTOR(false, false, __VA_ARGS__)
+#define VFA_CPP(...) VALUEFLOW_ADAPTOR(true, false, __VA_ARGS__)
+#define VFA_SLOW(...) VALUEFLOW_ADAPTOR(false, true, __VA_ARGS__)
 
 void ValueFlow::setValues(TokenList& tokenlist,
                           SymbolDatabase& symboldatabase,