Skip to content

Commit 84a2152

Browse files
author
Felix Faber
committed
Restoring TODO and fixing whitespace
1 parent 8e816e5 commit 84a2152

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

lib/importproject.cpp

+5-3
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ bool ImportProject::importSln(std::istream &istr, const std::string &path, const
450450
std::vector<SharedItemsProject> sharedItemsProjects{};
451451
while (std::getline(istr,line)) {
452452
if (!startsWith(line,"Project("))
453-
continue;
453+
continue;
454454
const std::string::size_type pos = line.find(".vcxproj");
455455
if (pos == std::string::npos)
456456
continue;
@@ -773,7 +773,9 @@ bool ImportProject::importVcxproj(const std::string &filename, std::map<std::str
773773
}
774774
}
775775
}
776-
}
776+
}
777+
// # TODO: support signedness of char via /J (and potential XML option for it)?
778+
// we can only set it globally but in this context it needs to be treated per file
777779

778780
// Include shared items project files
779781
std::vector<std::string> sharedItemsIncludePaths{};
@@ -806,7 +808,7 @@ bool ImportProject::importVcxproj(const std::string &filename, std::map<std::str
806808
FileSettings fs;
807809
fs.filename = cfilename;
808810
fs.cfg = p.name;
809-
// TODO: detect actual MSC version
811+
// TODO: detect actual MSC version
810812
fs.msc = true;
811813
fs.useMfc = useOfMfc;
812814
fs.defines = "_WIN32=1";

0 commit comments

Comments
 (0)