Fix #13268 FP: unusedFunction: [[maybe_unused]]

chrchr-github · chrchr-github · commit b8cc8b14e3b8 · 2024-10-26T18:33:22.000+02:00
diff --git a/lib/checkunusedfunctions.cpp b/lib/checkunusedfunctions.cpp
@@ -98,6 +98,10 @@ void CheckUnusedFunctions::parseTokens(const Tokenizer &tokenizer, const Setting
 
             FunctionUsage &usage = mFunctions[stripTemplateParameters(func->name())];
 
+            if (func->retDef && func->retDef->isAttributeMaybeUnused()) {
+                usage.usedOtherFile = true;
+            }
+
             if (!usage.lineNumber)
                 usage.lineNumber = func->token->linenr();
 
diff --git a/test/testunusedfunctions.cpp b/test/testunusedfunctions.cpp
@@ -501,6 +501,9 @@ class TestUnusedFunctions : public TestFixture {
         // #10661
         check("extern \"C\" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t dataSize) { return 0; }\n");
         ASSERT_EQUALS("", errout_str());
+
+        check("[[maybe_unused]] void f() {}"); // #13268
+        ASSERT_EQUALS("", errout_str());
     }
 
     void initializer_list() {

Original file line number	Diff line number	Diff line change
`@@ -501,6 +501,9 @@ class TestUnusedFunctions : public TestFixture {`
`501`	`501`	`// #10661`
`502`	`502`	`check("extern \"C\" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t dataSize) { return 0; }\n");`
`503`	`503`	`ASSERT_EQUALS("", errout_str());`
	`504`	`+`
	`505`	`+ check("[[maybe_unused]] void f() {}"); // #13268`
	`506`	`+ ASSERT_EQUALS("", errout_str());`
`504`	`507`	`}`
`505`	`508`
`506`	`509`	`void initializer_list() {`