refs #13617 - disallow using --debug --xml with multiple input file…

…s for now (#7280)
danmar · Feb 5, 2025 · ba73164 · ba73164
1 parent cdf9d6d
commit ba73164
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/cli/cmdlineparser.cpp b/cli/cmdlineparser.cpp
@@ -1600,6 +1600,12 @@ CmdLineParser::Result CmdLineParser::parseFromArgs(int argc, const char* const a
         mFileSettings = project.fileSettings;
     }
 
+    if (mSettings.debugnormal && mSettings.outputFormat == Settings::OutputFormat::xml && (mPathNames.size() > 1 || mFileSettings.size() > 1))
+    {
+        mLogger.printError("printing debug output in XML format does not support multiple input files.");
+        return Result::Fail;
+    }
+
     // Use paths _pathnames if no base paths for relative path output are given
     if (mSettings.basePaths.empty() && mSettings.relativePaths)
         mSettings.basePaths = mPathNames;

diff --git a/test/testcmdlineparser.cpp b/test/testcmdlineparser.cpp
@@ -424,6 +424,8 @@ class TestCmdlineParser : public TestFixture {
         TEST_CASE(maxTemplateRecursionMissingCount);
         TEST_CASE(emitDuplicates);
         TEST_CASE(debugClangOutput);
+        TEST_CASE(debugXmlMultiple);
+        TEST_CASE(debugNormalXmlMultiple);
 
         TEST_CASE(ignorepaths1);
         TEST_CASE(ignorepaths2);
@@ -2926,6 +2928,20 @@ class TestCmdlineParser : public TestFixture {
         ASSERT_EQUALS(true, settings->debugClangOutput);
     }
 
+    void debugXmlMultiple() {
+        REDIRECT;
+        const char * const argv[] = {"cppcheck", "--debug", "--xml", "1.cpp", "2.cpp"};
+        ASSERT_EQUALS_ENUM(CmdLineParser::Result::Fail, parser->parseFromArgs(5, argv));
+        ASSERT_EQUALS("cppcheck: error: printing debug output in XML format does not support multiple input files.\n", logger->str());
+    }
+
+    void debugNormalXmlMultiple() {
+        REDIRECT;
+        const char * const argv[] = {"cppcheck", "--debug-normal", "--xml", "1.cpp", "2.cpp"};
+        ASSERT_EQUALS_ENUM(CmdLineParser::Result::Fail, parser->parseFromArgs(5, argv));
+        ASSERT_EQUALS("cppcheck: error: printing debug output in XML format does not support multiple input files.\n", logger->str());
+    }
+
     void ignorepaths1() {
         REDIRECT;
         const char * const argv[] = {"cppcheck", "-isrc", "file.cpp"};