Skip to content

Commit e624ec4

Browse files
committed
Nits 4
1 parent d0ed8f3 commit e624ec4

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

Diff for: cfg/qt.cfg

+2-2
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@
5959
<reflection>
6060
<call arg="2">invokeMethod</call>
6161
</reflection>
62-
<!-- <define name="SIGNAL(X)" value="#X"/> -->
63-
<!-- <define name="SLOT(X)" value="#X"/> -->
62+
<define name="SIGNAL(X)" value="X"/>
63+
<define name="SLOT(X)" value="X"/>
6464
<!-- T qAbs(const T &t) -->
6565
<function name="qAbs">
6666
<pure/>

Diff for: test/cfg/qt.cpp

+6-5
Original file line numberDiff line numberDiff line change
@@ -814,16 +814,17 @@ struct DQObject_missingOverride : BQObject_missingOverride {
814814
};
815815

816816
namespace {
817-
class Foo { // #13236
818-
Foo();
817+
class TestUnusedFunction { // #13236
818+
TestUnusedFunction();
819819
// cppcheck-suppress functionStatic
820820
void doStuff();
821821
};
822822

823-
Foo::Foo() {
823+
TestUnusedFunction::TestUnusedFunction() {
824+
Computations comp;
824825
// cppcheck-suppress [checkLibraryFunction, checkLibraryNoReturn]
825-
connect(a, SIGNAL(doStuff()), this, SLOT(doStuff()));
826+
connect(&comp, SIGNAL(doStuff()), this, SLOT(doStuff()));
826827
}
827828

828-
void Foo::doStuff() {} // Should not warn here with unusedFunction
829+
void TestUnusedFunction::doStuff() {} // Should not warn here with unusedFunction
829830
}

0 commit comments

Comments
 (0)