Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

DI #44

Open
cawa87 opened this issue Nov 7, 2014 · 8 comments
Open

DI #44

cawa87 opened this issue Nov 7, 2014 · 8 comments
Assignees
@malukenho
Labels
feature WIP
Milestone
2.0.0

Comments

@cawa87
Copy link

cawa87 commented Nov 7, 2014

Hey, nice router.
But it would be nice if it'll have and mechanism to inject some dependencies in controller\action.
@malukenho
Copy link

@CawaKharkov It's a great ideia!
have you thinking in anything?

@cawa87
Copy link
Author

cawa87 commented Nov 12, 2014

@malukenho I've modified router to inject service container.

@cawa87
Copy link
Author

cawa87 commented Nov 12, 2014

And I think it would be nice, if user want to inject something to your controller you need to implement some interface InjectableInterface. And when calling dispatch inject container(or some service) to your controller.

@malukenho
Copy link

@CawaKharkov can you open a PR please? :D

@malukenho malukenho self-assigned this Nov 12, 2014
@malukenho malukenho added this to the 2.0.0 milestone Nov 12, 2014
@cawa87
Copy link
Author

cawa87 commented Nov 12, 2014

@malukenho #45 PR

@mbunge
Copy link

mbunge commented Oct 15, 2015

It would be cool to use as foundation.
https://github.com/container-interop/container-interop

And nobody is forced to use a specific DI-Package.

@mo-ba
Copy link

mo-ba commented May 30, 2016

i think routing and DI are different concerns and should not be mixed...

@malukenho
Copy link

@mo-ba It's not about mix, It's about support.

malukenho pushed a commit that referenced this issue Dec 19, 2016
#44 — composer require container-interop/container-interop
643d4fd
malukenho pushed a commit that referenced this issue Dec 19, 2016
#44 — pass container to Router via constructor
871df3b
malukenho pushed a commit that referenced this issue Dec 19, 2016
#44 — Add todo
34ca1f9
malukenho pushed a commit that referenced this issue Dec 19, 2016
#44 — Make container not mandatory
3587b35
malukenho pushed a commit that referenced this issue Dec 19, 2016
#44 — Work with container Interop interface for DI
4f44473
malukenho pushed a commit that referenced this issue Dec 19, 2016
#44 — Fix test error due missing SomeController
2d05727
malukenho pushed a commit that referenced this issue Dec 19, 2016
#44 — Guard controller and action name when instantiate the Route object
8894114
malukenho pushed a commit that referenced this issue Dec 19, 2016
#44 — Added router tests for use of Di containers
ae13216
malukenho pushed a commit that referenced this issue Dec 19, 2016
#44 — Remove duplicated call_user_func_array_code
fea9a8d
malukenho pushed a commit that referenced this issue Dec 19, 2016
#44 — Test throw exception in case of null action
9a3b951
malukenho pushed a commit that referenced this issue Apr 25, 2017
#44 — composer require container-interop/container-interop
a396cb7
malukenho pushed a commit that referenced this issue Apr 25, 2017
#44 — pass container to Router via constructor
c8a9c4f
malukenho pushed a commit that referenced this issue Apr 25, 2017
#44 — Add todo
e6214e3
malukenho pushed a commit that referenced this issue Apr 25, 2017
#44 — Make container not mandatory
cce97c2
malukenho pushed a commit that referenced this issue Apr 25, 2017
#44 — Work with container Interop interface for DI
4d8918a
malukenho pushed a commit that referenced this issue Apr 25, 2017
#44 — Fix test error due missing SomeController
7fb11a8
malukenho pushed a commit that referenced this issue Apr 25, 2017
#44 — Guard controller and action name when instantiate the Route object
d1ce0d9
malukenho pushed a commit that referenced this issue Apr 25, 2017
#44 — Added router tests for use of Di containers
44a2594
malukenho pushed a commit that referenced this issue Apr 25, 2017
#44 — Remove duplicated call_user_func_array_code
7e0d58c
malukenho pushed a commit that referenced this issue Apr 25, 2017
#44 — Test throw exception in case of null action
26916ac
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@malukenho malukenho

Labels
feature WIP
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@mbunge @cawa87 @malukenho @mo-ba