Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

term_order in CPT detail not working #6

Open
2 tasks
daomapsieucap opened this issue Jun 6, 2022 · 4 comments
Open
2 tasks

term_order in CPT detail not working #6

daomapsieucap opened this issue Jun 6, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@daomapsieucap
Copy link
Owner

Feature request

  • Enable drag and drop tag in edit CPT.
  • Show tags by term_order in each CPT.
@daomapsieucap daomapsieucap added the enhancement New feature or request label Jun 6, 2022
@daomapsieucap daomapsieucap self-assigned this Jun 6, 2022
@daomapsieucap
Copy link
Owner Author

@phongkhuu115 Check if all the features requested are implemented or not.

Currently, we did have a bug existing: When we have existing terms (without enabling term_order before creating these terms), then we enable term_order in Fiber Admin. The terms won't go in the correct order. I think because Fiber Admin doesn't create / update correct term_order when we enable term_order with existing term.

@phongkhuu115
Copy link
Contributor

@daomapsieucap I don't think the issue still exists, as soon as I turn the feature on for the new create taxonomy, all its terms are automatically sorted by their term_order

@daomapsieucap
Copy link
Owner Author

@phongkhuu115 I confirmed that the issue still exists. Please try to re-produce all the steps I mentioned and show terms on FE using term_order. "The terms won't go in the correct order" will happen on FE.

@phongkhuu115
Copy link
Contributor

@daomapsieucap May I ask for more details? Because I can't reproduce the problem

This is what I have done:

  1. Create new Taxonomy and CPT
  2. Create a number of terms
  3. Show terms on FE by term_order
  4. Enable drag-and-drop for Taxonomy
  5. Shuffle order

But I don't see any problem.

Newly created (no change is made): This look correct because default it's order by name

image

Show on FE: I used term_order here

image

Enable drag and drop:

image

Show on FE: Although all term order is 0, but it's the same with admin site

image

My test code:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants