feedback refactor allowed values name

Signed-off-by: Filinto Duran <[email protected]>

Author: filintod

pkg/runfileconfig/run_file_config_parser.go

@@ -26,6 +26,8 @@ import (
 	"gopkg.in/yaml.v2"
 )
 
+var imagePullPolicyValuesAllowed = []string{"Always", "Never", "IfNotPresent"}
+
 // Parse the provided run file into a RunFileConfig struct.
 func (a *RunFileConfig) parseAppsConfig(runFilePath string) error {
 	var err error
@@ -100,9 +102,8 @@ func (a *RunFileConfig) validateRunConfig(runFilePath string) error {
 
 		// Check containerImagePullPolicy is valid
 		if a.Apps[i].ContainerImagePullPolicy != "" {
-			allowedValues := []string{"Always", "Never", "IfNotPresent"}
-			if !utils.Contains(allowedValues, a.Apps[i].ContainerImagePullPolicy) {
-				return fmt.Errorf("invalid containerImagePullPolicy: %s, allowed values: %v", a.Apps[i].ContainerImagePullPolicy, allowedValues)
+			if !utils.Contains(imagePullPolicyValuesAllowed, a.Apps[i].ContainerImagePullPolicy) {
+				return fmt.Errorf("invalid containerImagePullPolicy: %s, allowed values: %s", a.Apps[i].ContainerImagePullPolicy, strings.Join(imagePullPolicyValuesAllowed, ", "))
 			}
 		} else {
 			a.Apps[i].ContainerImagePullPolicy = "Always"