fix: correct majority of the testifylinter issues relating to error assertions

Signed-off-by: mikeee <[email protected]>

Author: mikeee

.github/workflows/dapr-bot/bot_test.go

@@ -10,7 +10,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-var testBot *Bot = &Bot{
+var testBot = &Bot{
 	ctx:         context.Background(),
 	issueClient: &testClient{},
 }
@@ -50,7 +50,7 @@ func TestHandleEvent(t *testing.T) {
 		}
 		testEventCopy.IssueCommentEvent.Comment.Body = github.String("/assign")
 		res, err := testBot.HandleEvent(ctx, testEventCopy)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.NotEmpty(t, res)
 	})
 
@@ -67,7 +67,7 @@ func TestHandleEvent(t *testing.T) {
 		}
 		testEventCopy.IssueCommentEvent.Comment.Body = github.String("/assign \r \ntest body")
 		res, err := testBot.HandleEvent(ctx, testEventCopy)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.NotEmpty(t, res)
 	})
 
@@ -84,7 +84,7 @@ func TestHandleEvent(t *testing.T) {
 		}
 		testEventCopy.IssueCommentEvent.Comment.Body = github.String("/assign")
 		res, err := testBot.HandleEvent(ctx, testEventCopy)
-		assert.Error(t, err)
+		require.Error(t, err)
 		assert.NotEmpty(t, res)
 	})
 
@@ -99,7 +99,7 @@ func TestHandleEvent(t *testing.T) {
 		}
 		testEventCopy.IssueCommentEvent.Comment.Body = github.String("assign")
 		res, err := testBot.HandleEvent(ctx, testEventCopy)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, "no command found", res)
 	})
 }
@@ -111,7 +111,7 @@ func TestCreateIssueComment(t *testing.T) {
 		}
 		testBot.issueClient = &tc
 		err := testBot.CreateIssueComment("test", testEvent)
-		assert.Error(t, err)
+		require.Error(t, err)
 	})
 
 	t.Run("create issue comment", func(t *testing.T) {
@@ -120,7 +120,7 @@ func TestCreateIssueComment(t *testing.T) {
 		}
 		testBot.issueClient = &tc
 		err := testBot.CreateIssueComment("test", testEvent)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 	})
 
 	t.Run("create issue comment with empty body", func(t *testing.T) {
@@ -129,7 +129,7 @@ func TestCreateIssueComment(t *testing.T) {
 		}
 		testBot.issueClient = &tc
 		err := testBot.CreateIssueComment("", testEvent)
-		assert.Error(t, err)
+		require.Error(t, err)
 	})
 }
 
@@ -140,7 +140,7 @@ func TestAssignIssueToCommenter(t *testing.T) {
 		}
 		testBot.issueClient = &tc
 		assignee, err := testBot.AssignIssueToCommenter(testEvent)
-		assert.Error(t, err)
+		require.Error(t, err)
 		assert.Empty(t, assignee)
 	})
 
@@ -156,7 +156,7 @@ func TestAssignIssueToCommenter(t *testing.T) {
 		}
 		testEventCopy.IssueCommentEvent.Issue.Assignees = []*github.User{}
 		assignee, err := testBot.AssignIssueToCommenter(testEventCopy)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, "testCommentLogin", assignee)
 	})
 
@@ -170,7 +170,7 @@ func TestAssignIssueToCommenter(t *testing.T) {
 		}
 		testEventCopy.IssueCommentEvent.Issue.State = github.String("closed")
 		assignee, err := testBot.AssignIssueToCommenter(testEventCopy)
-		assert.Error(t, err)
+		require.Error(t, err)
 		assert.Empty(t, assignee)
 	})
 
@@ -184,7 +184,7 @@ func TestAssignIssueToCommenter(t *testing.T) {
 		}
 		testEventCopy.IssueCommentEvent.Issue.Assignees = []*github.User{{Login: github.String("testCommentLogin")}}
 		assignee, err := testBot.AssignIssueToCommenter(testEventCopy)
-		assert.Error(t, err)
+		require.Error(t, err)
 		assert.Empty(t, assignee)
 	})
 
@@ -200,7 +200,7 @@ func TestAssignIssueToCommenter(t *testing.T) {
 		}
 		testEventCopy.IssueCommentEvent.Issue.Assignees = []*github.User{{Login: github.String("testCommentLogin2")}}
 		assignee, err := testBot.AssignIssueToCommenter(testEventCopy)
-		assert.Error(t, err)
+		require.Error(t, err)
 		assert.Empty(t, assignee)
 	})
 }

.github/workflows/dapr-bot/event_test.go

@@ -10,7 +10,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-var testEvent Event = Event{
+var testEvent = Event{
 	Type: "issue_comment",
 	Path: "test/test",
 	IssueCommentEvent: &github.IssueCommentEvent{
@@ -36,14 +36,14 @@ func TestProcessEvent(t *testing.T) {
 	}
 	t.Run("process event", func(t *testing.T) {
 		event, err := ProcessEvent(testEvent.Type, testEvent.Path, testEventData)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.NotNil(t, event)
 		assert.Equal(t, "test/test", event.Path)
 	})
 
 	t.Run("process event with empty path", func(t *testing.T) {
 		event, err := ProcessEvent(testEvent.Type, "", testEventData)
-		assert.Error(t, err)
+		require.Error(t, err)
 		assert.Empty(t, event)
 	})
 
@@ -53,14 +53,14 @@ func TestProcessEvent(t *testing.T) {
 
 	t.Run("process issue_comment event", func(t *testing.T) {
 		event, err := ProcessEvent(testEvent.Type, testEvent.Path, testEventData)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.NotNil(t, event)
 		assert.Equal(t, "issue_comment", event.Type)
 	})
 
 	t.Run("process invalid event", func(t *testing.T) {
 		event, err := ProcessEvent(testEvent.Type, testEvent.Path, randomData.Bytes())
-		assert.Error(t, err)
+		require.Error(t, err)
 		assert.Empty(t, event)
 	})
 }

actor/manager/container_test.go

@@ -72,7 +72,7 @@ func TestContainerInvoke(t *testing.T) {
 	mockCodec.EXPECT().Unmarshal([]byte(param), gomock.Any()).SetArg(1, "param").Return(nil)
 
 	rsp, err := container.Invoke("Invoke", []byte(param))
-	require.Equal(t, 2, len(rsp))
+	require.Len(t, rsp, 2)
 	require.Equal(t, actorErr.Success, err)
 	assert.Equal(t, param, rsp[0].Interface().(string))
 }