fix: perfsprint recommendations

Signed-off-by: Mike Nguyen <[email protected]>

Author: mikeee

service/grpc/binding.go

@@ -27,10 +27,10 @@ import (
 // AddBindingInvocationHandler appends provided binding invocation handler with its name to the service.
 func (s *Server) AddBindingInvocationHandler(name string, fn common.BindingInvocationHandler) error {
 	if name == "" {
-		return fmt.Errorf("binding name required")
+		return errors.New("binding name required")
 	}
 	if fn == nil {
-		return fmt.Errorf("binding handler required")
+		return errors.New("binding handler required")
 	}
 	s.bindingHandlers[name] = fn
 	return nil

service/grpc/health_check.go

@@ -15,7 +15,7 @@ package grpc
 
 import (
 	"context"
-	"fmt"
+	"errors"
 
 	pb "github.com/dapr/dapr/pkg/proto/runtime/v1"
 	"github.com/dapr/go-sdk/service/common"
@@ -26,7 +26,7 @@ import (
 // AddHealthCheckHandler appends provided app health check handler.
 func (s *Server) AddHealthCheckHandler(_ string, fn common.HealthCheckHandler) error {
 	if fn == nil {
-		return fmt.Errorf("health check handler required")
+		return errors.New("health check handler required")
 	}
 
 	s.healthCheckHandler = fn
@@ -44,5 +44,5 @@ func (s *Server) HealthCheck(ctx context.Context, _ *emptypb.Empty) (*pb.HealthC
 		return &pb.HealthCheckResponse{}, nil
 	}
 
-	return nil, fmt.Errorf("health check handler not implemented")
+	return nil, errors.New("health check handler not implemented")
 }

service/grpc/invoke.go

@@ -28,15 +28,15 @@ import (
 // AddServiceInvocationHandler appends provided service invocation handler with its method to the service.
 func (s *Server) AddServiceInvocationHandler(method string, fn cc.ServiceInvocationHandler) error {
 	if method == "" || method == "/" {
-		return fmt.Errorf("servie name required")
+		return errors.New("service name required")
 	}
 
 	if method[0] == '/' {
 		method = method[1:]
 	}
 
 	if fn == nil {
-		return fmt.Errorf("invocation handler required")
+		return errors.New("invocation handler required")
 	}
 	s.invokeHandlers[method] = fn
 	return nil

service/http/binding.go

@@ -14,7 +14,7 @@ limitations under the License.
 package http
 
 import (
-	"fmt"
+	"errors"
 	"io"
 	"net/http"
 	"strings"
@@ -25,14 +25,14 @@ import (
 // AddBindingInvocationHandler appends provided binding invocation handler with its route to the service.
 func (s *Server) AddBindingInvocationHandler(route string, fn common.BindingInvocationHandler) error {
 	if route == "" {
-		return fmt.Errorf("binding route required")
+		return errors.New("binding route required")
 	}
 	if fn == nil {
-		return fmt.Errorf("binding handler required")
+		return errors.New("binding handler required")
 	}
 
 	if !strings.HasPrefix(route, "/") {
-		route = fmt.Sprintf("/%s", route)
+		route = "/" + route
 	}
 
 	s.mux.Handle(route, optionsHandler(http.HandlerFunc(

service/http/health_check.go

@@ -14,7 +14,7 @@ limitations under the License.
 package http
 
 import (
-	"fmt"
+	"errors"
 	"net/http"
 	"strings"
 
@@ -24,11 +24,11 @@ import (
 // AddHealthCheckHandler appends provided app health check handler.
 func (s *Server) AddHealthCheckHandler(route string, fn common.HealthCheckHandler) error {
 	if fn == nil {
-		return fmt.Errorf("health check handler required")
+		return errors.New("health check handler required")
 	}
 
 	if !strings.HasPrefix(route, "/") {
-		route = fmt.Sprintf("/%s", route)
+		route = "/" + route
 	}
 
 	s.mux.Handle(route, optionsHandler(http.HandlerFunc(

service/http/invoke.go

@@ -14,7 +14,7 @@ limitations under the License.
 package http
 
 import (
-	"fmt"
+	"errors"
 	"io"
 	"net/http"
 	"strings"
@@ -27,11 +27,11 @@ import (
 // AddServiceInvocationHandler appends provided service invocation handler with its route to the service.
 func (s *Server) AddServiceInvocationHandler(route string, fn common.ServiceInvocationHandler) error {
 	if route == "" || route == "/" {
-		return fmt.Errorf("service route required")
+		return errors.New("service route required")
 	}
 
 	if fn == nil {
-		return fmt.Errorf("invocation handler required")
+		return errors.New("invocation handler required")
 	}
 
 	if !strings.HasPrefix(route, "/") {

service/http/scheduling.go

@@ -2,17 +2,16 @@ package http
 
 import (
 	"errors"
-	"fmt"
 
 	"github.com/dapr/go-sdk/service/common"
 )
 
 func (s *Server) AddJobEventHandler(name string, fn common.JobEventHandler) error {
 	if name == "" {
-		return fmt.Errorf("job event name required")
+		return errors.New("job event name required")
 	}
 	if fn == nil {
-		return fmt.Errorf("job event handler required")
+		return errors.New("job event handler required")
 	}
 
 	return errors.New("handling http scheduling requests has not been implemented in this sdk")

service/internal/topicregistrar.go

@@ -2,7 +2,6 @@ package internal
 
 import (
 	"errors"
-	"fmt"
 
 	"github.com/dapr/go-sdk/service/common"
 )
@@ -27,7 +26,7 @@ func (m TopicRegistrar) AddSubscription(sub *common.Subscription, fn common.Topi
 		return errors.New("pub/sub name required")
 	}
 	if fn == nil {
-		return fmt.Errorf("topic handler required")
+		return errors.New("topic handler required")
 	}
 
 	var key string