From 84bd635daf6fc4e1214eb3191f612408f4a1abba Mon Sep 17 00:00:00 2001 From: mikeee Date: Thu, 7 Dec 2023 12:53:27 +0000 Subject: [PATCH] fix: correct test cases Signed-off-by: mikeee --- client/pubsub_test.go | 24 ++++++++++++------------ client/state_test.go | 8 ++++---- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/client/pubsub_test.go b/client/pubsub_test.go index cf5f2da5..c125ab8b 100644 --- a/client/pubsub_test.go +++ b/client/pubsub_test.go @@ -116,14 +116,14 @@ func TestPublishEvents(t *testing.T) { t.Run("with data", func(t *testing.T) { res := testClient.PublishEvents(ctx, "messages", "test", []interface{}{"ping", "pong"}) - assert.Nil(t, res.Error) - assert.Len(t, res.FailedEvents, 0) + require.NoError(t, res.Error) + assert.Empty(t, res.FailedEvents) }) t.Run("without data", func(t *testing.T) { res := testClient.PublishEvents(ctx, "messages", "test", nil) - assert.Nil(t, res.Error) - assert.Len(t, res.FailedEvents, 0) + require.NoError(t, res.Error) + assert.Empty(t, res.FailedEvents) }) t.Run("with struct data", func(t *testing.T) { @@ -157,8 +157,8 @@ func TestPublishEvents(t *testing.T) { for _, tc := range testcases { t.Run(tc.name, func(t *testing.T) { res := testClient.PublishEvents(ctx, "messages", "test", []interface{}{tc.data}) - assert.Nil(t, res.Error) - assert.Len(t, res.FailedEvents, 0) + require.NoError(t, res.Error) + assert.Empty(t, res.FailedEvents) }) } }) @@ -172,20 +172,20 @@ func TestPublishEvents(t *testing.T) { t.Run("with raw payload", func(t *testing.T) { res := testClient.PublishEvents(ctx, "messages", "test", []interface{}{"ping", "pong"}, PublishEventsWithRawPayload()) - assert.Nil(t, res.Error) - assert.Len(t, res.FailedEvents, 0) + require.NoError(t, res.Error) + assert.Empty(t, res.FailedEvents) }) t.Run("with metadata", func(t *testing.T) { res := testClient.PublishEvents(ctx, "messages", "test", []interface{}{"ping", "pong"}, PublishEventsWithMetadata(map[string]string{"key": "value"})) - assert.Nil(t, res.Error) - assert.Len(t, res.FailedEvents, 0) + require.NoError(t, res.Error) + assert.Empty(t, res.FailedEvents) }) t.Run("with custom content type", func(t *testing.T) { res := testClient.PublishEvents(ctx, "messages", "test", []interface{}{"ping", "pong"}, PublishEventsWithContentType("text/plain")) - assert.Nil(t, res.Error) - assert.Len(t, res.FailedEvents, 0) + require.NoError(t, res.Error) + assert.Empty(t, res.FailedEvents) }) t.Run("with events that will fail some events", func(t *testing.T) { diff --git a/client/state_test.go b/client/state_test.go index 7a74d52e..2c3f752e 100644 --- a/client/state_test.go +++ b/client/state_test.go @@ -227,7 +227,7 @@ func TestDeleteBulkState(t *testing.T) { // confirm data deleted getItems, err = testClient.GetBulkState(ctx, store, keys, nil, 1) require.NoError(t, err) - assert.Equal(t, 0, len(getItems)) + assert.Empty(t, getItems) }) t.Run("delete exist data with stateItem", func(t *testing.T) { @@ -272,7 +272,7 @@ func TestDeleteBulkState(t *testing.T) { // confirm data deleted getItems, err = testClient.GetBulkState(ctx, store, keys, nil, 1) require.NoError(t, err) - assert.Equal(t, 0, len(getItems)) + assert.Empty(t, getItems) }) } @@ -346,7 +346,7 @@ func TestStateTransactions(t *testing.T) { items, err := testClient.GetBulkState(ctx, store, keys, nil, 3) require.NoError(t, err) assert.NotNil(t, items) - assert.Len(t, items, 0) + assert.Empty(t, items) }) } @@ -377,7 +377,7 @@ func TestQueryState(t *testing.T) { query := `{}` resp, err := testClient.QueryStateAlpha1(ctx, store, query, nil) require.NoError(t, err) - assert.Equal(t, 2, len(resp.Results)) + assert.Len(t, resp.Results, 2) for _, item := range resp.Results { assert.True(t, item.Key == key1 || item.Key == key2) assert.Equal(t, []byte(data), item.Value)