fix: correct state consistency types

Signed-off-by: mikeee <[email protected]>

Author: mikeee

client/state.go

@@ -46,6 +46,19 @@ const (
 	StateOperationTypeUpsert OperationType = 1
 	// StateOperationTypeDelete represents delete operation type value.
 	StateOperationTypeDelete OperationType = 2
+
+	// EventualType represents the eventual type value.
+	EventualType = "eventual"
+	// StrongType represents the strong type value.
+	StrongType = "strong"
+	// FirstWriteType represents the first write type value.
+	FirstWriteType = "first-write"
+	// LastWriteType represents the last write type value.
+	LastWriteType = "last-write"
+	// UpsertType represents the upsert type value.
+	UpsertType = "upsert"
+	// DeleteType represents the delete type value.
+	DeleteType = "delete"
 	// UndefinedType represents undefined type value.
 	UndefinedType = "undefined"
 )
@@ -73,8 +86,8 @@ func (s StateConcurrency) GetPBConcurrency() v1.StateOptions_StateConcurrency {
 func (o OperationType) String() string {
 	names := [...]string{
 		UndefinedType,
-		"upsert",
-		"delete",
+		UpsertType,
+		DeleteType,
 	}
 	if o < StateOperationTypeUpsert || o > StateOperationTypeDelete {
 		return UndefinedType
@@ -87,8 +100,8 @@ func (o OperationType) String() string {
 func (s StateConsistency) String() string {
 	names := [...]string{
 		UndefinedType,
-		"eventual",
-		"strong",
+		EventualType,
+		StrongType,
 	}
 	if s < StateConsistencyEventual || s > StateConsistencyStrong {
 		return UndefinedType
@@ -101,8 +114,8 @@ func (s StateConsistency) String() string {
 func (s StateConcurrency) String() string {
 	names := [...]string{
 		UndefinedType,
-		"first-write",
-		"last-write",
+		FirstWriteType,
+		LastWriteType,
 	}
 	if s < StateConcurrencyFirstWrite || s > StateConcurrencyLastWrite {
 		return UndefinedType

client/state_test.go

@@ -35,19 +35,19 @@ func TestTypes(t *testing.T) {
 		var a OperationType = -1
 		assert.Equal(t, UndefinedType, a.String())
 		a = 2
-		assert.Equal(t, "delete", a.String())
+		assert.Equal(t, DeleteType, a.String())
 	})
 	t.Run("test state concurrency type", func(t *testing.T) {
 		var b StateConcurrency = -1
 		assert.Equal(t, UndefinedType, b.String())
 		b = 2
-		assert.Equal(t, "last-write", b.String())
+		assert.Equal(t, LastWriteType, b.String())
 	})
 	t.Run("test state consistency type", func(t *testing.T) {
 		var c StateConsistency = -1
 		assert.Equal(t, UndefinedType, c.String())
 		c = 2
-		assert.Equal(t, "strong", c.String())
+		assert.Equal(t, StrongType, c.String())
 	})
 }