-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds DAPR_GRPC_ENPOINT
support to client
#475
Conversation
PR adds `DAPR_GRPC_ENPOINT` environment variable support to client. Address parser respects http[s] schemes, and TLS query options, as per [0008-S-sidecar-endpoint-tls.md](https://github.com/dapr/proposals/blob/main/0008-S-sidecar-endpoint-tls.md). `DAPR_GRPC_ENDPONT` takes precedence over `DAPR_GRPC_PORT`. Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
+ Coverage 68.96% 69.71% +0.74%
==========================================
Files 34 35 +1
Lines 2707 2843 +136
==========================================
+ Hits 1867 1982 +115
- Misses 732 746 +14
- Partials 108 115 +7
☔ View full report in Codecov by Sentry. |
Are the |
@mikeee cpuld you elaborate? |
In the parser lines 168-169 the grpc/s schemas are permitted yet not parsed as there is no handling for those schemas e.g. |
"grpc", | ||
"grpcs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although known, these weren't specified by the proposal and aren't handled in this function otherwise. Should they still be included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mikeee, indeed these should be removed.
* Adds `DAPR_GRPC_ENPOINT` support to client PR adds `DAPR_GRPC_ENPOINT` environment variable support to client. Address parser respects http[s] schemes, and TLS query options, as per [0008-S-sidecar-endpoint-tls.md](https://github.com/dapr/proposals/blob/main/0008-S-sidecar-endpoint-tls.md). `DAPR_GRPC_ENDPONT` takes precedence over `DAPR_GRPC_PORT`. Signed-off-by: joshvanl <[email protected]> * Remove errors.Join to have compatibility with Go 1.19 Signed-off-by: joshvanl <[email protected]> --------- Signed-off-by: joshvanl <[email protected]>
PR adds
DAPR_GRPC_ENPOINT
environment variable support to client.Address parser respects http[s] schemes, and TLS query options, as per 0008-S-sidecar-endpoint-tls.md.
DAPR_GRPC_ENDPONT
takes precedence overDAPR_GRPC_PORT
.