Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for error handling #482

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Docs for error handling #482

merged 3 commits into from
Jan 19, 2024

Conversation

elena-kolevska
Copy link
Contributor

Depends on/is relevant for dapr/dapr#7257

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04f7b59) 70.08% compared to head (35df5e1) 70.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #482   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files          35       35           
  Lines        2841     2841           
=======================================
  Hits         1991     1991           
  Misses        738      738           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elena-kolevska elena-kolevska marked this pull request as ready for review December 11, 2023 15:23
@elena-kolevska elena-kolevska requested a review from a team as a code owner December 11, 2023 15:23
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well written.

LGTM 👍

@sadath-12
Copy link
Contributor

LGTM 🙌

@elena-kolevska
Copy link
Contributor Author

Hey folks, are we good to merge this?

@yaron2 yaron2 merged commit 1ad973a into dapr:main Jan 19, 2024
7 checks passed
mikeee pushed a commit to mikeee/dapr_go-sdk that referenced this pull request Jan 19, 2024
* Updates docs with error handling example

Signed-off-by: Elena Kolevska <[email protected]>

* Adds docs for handling handling error details

Signed-off-by: Elena Kolevska <[email protected]>

* Updates main readme with example for handling error details

Signed-off-by: Elena Kolevska <[email protected]>

---------

Signed-off-by: Elena Kolevska <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants