We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DaprContainer withComponent(path) correctly parses the type field.
DaprContainer withComponent(path) incorrectly parses the type field.
The type is read from the root level:
java-sdk/testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java
Line 213 in daf4c8b
But the type is actually stored in the spec:
java-sdk/testcontainers-dapr/src/test/resources/dapr-resources/statestore.yaml
Line 6 in daf4c8b
The test currently passes because it replaces the actual type with null, but should be state.redis:
null
state.redis
java-sdk/testcontainers-dapr/src/test/java/io/dapr/testcontainers/DaprComponentTest.java
Line 72 in daf4c8b
Change the expected type to state.redis in the DaprComponentTest and observe the failure.
NOTE: withComponent(path) is also parsing the spec.metadata incorrectly.
The expected metadata should match that in the statestore.yaml file:
const expectedComponentYaml = "apiVersion: dapr.io/v1alpha1\n" + "kind: Component\n" + "metadata:\n" + " name: statestore\n" + "spec:\n" + " type: state.redis\n" + " version: v1\n" + " metadata:\n" + " - name: keyPrefix\n" + " value: name\n" + " - name: redisHost\n" + " value: redis:6379\n" + " - name: redisPassword\n" + " value: \"\"\n"
RELEASE NOTE:
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Expected Behavior
DaprContainer withComponent(path) correctly parses the type field.
Actual Behavior
DaprContainer withComponent(path) incorrectly parses the type field.
The type is read from the root level:
java-sdk/testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java
Line 213 in daf4c8b
But the type is actually stored in the spec:
java-sdk/testcontainers-dapr/src/test/resources/dapr-resources/statestore.yaml
Line 6 in daf4c8b
The test currently passes because it replaces the actual type with
null
, but should bestate.redis
:java-sdk/testcontainers-dapr/src/test/java/io/dapr/testcontainers/DaprComponentTest.java
Line 72 in daf4c8b
Steps to Reproduce the Problem
Change the expected type to
state.redis
in the DaprComponentTest and observe the failure.NOTE: withComponent(path) is also parsing the spec.metadata incorrectly.
The expected metadata should match that in the statestore.yaml file:
Release Note
RELEASE NOTE:
The text was updated successfully, but these errors were encountered: