Skip to content

Commit d33c5a4

Browse files
authored
fix flaky integration test DemoActorReminderOnceImpl (#553)
* add undefined type Signed-off-by: MregXN <[email protected]> * npm run pretty-fix Signed-off-by: MregXN <[email protected]> * add undefind type for ttl Signed-off-by: MregXN <[email protected]> * add undefind type Signed-off-by: MregXN <[email protected]> * make type optional Signed-off-by: MregXN <[email protected]> --------- Signed-off-by: MregXN <[email protected]>
1 parent 2d41bc8 commit d33c5a4

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

Diff for: daprdocs/content/en/js-sdk-docs/js-server/_index.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ const daprServer = new DaprServer({
112112
serverPort: "50002", // App Port
113113
serverHttp: myApp,
114114
clientOptions: {
115-
daprHost,
116-
daprPort,
115+
daprHost
116+
daprPort
117117
}
118118
});
119119

Diff for: src/actors/runtime/AbstractActor.ts

100644100755
+2-2
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export default abstract class AbstractActor {
9595
async registerActorReminder<_Type>(
9696
reminderName: string,
9797
dueTime: Temporal.Duration,
98-
period: Temporal.Duration,
98+
period?: Temporal.Duration,
9999
ttl?: Temporal.Duration,
100100
state?: any,
101101
) {
@@ -115,7 +115,7 @@ export default abstract class AbstractActor {
115115
timerName: string,
116116
callback: string,
117117
dueTime: Temporal.Duration,
118-
period: Temporal.Duration,
118+
period?: Temporal.Duration,
119119
ttl?: Temporal.Duration,
120120
state?: any,
121121
) {

Diff for: src/types/ActorReminder.type.ts

100644100755
+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ limitations under the License.
1414
import { Temporal } from "@js-temporal/polyfill";
1515

1616
export type ActorReminderType = {
17-
period: Temporal.Duration; // e.g. 0h0m9s0ms
17+
period?: Temporal.Duration; // e.g. 0h0m9s0ms
1818
dueTime?: Temporal.Duration; // e.g. 1m or 0h0m0s0ms defaults to 0s
1919
data?: any; // the data to pass
2020
ttl?: Temporal.Duration; // e.g. 1m

Diff for: src/types/ActorTimer.type.ts

100644100755
+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ limitations under the License.
1414
import { Temporal } from "@js-temporal/polyfill";
1515

1616
export type ActorTimerType = {
17-
period: Temporal.Duration; // e.g. 0h0m9s0ms
17+
period?: Temporal.Duration; // e.g. 0h0m9s0ms
1818
dueTime?: Temporal.Duration; // e.g. 1m or 0h0m0s0ms defaults to 0s
1919
data?: any; // the data to pass
2020
ttl?: Temporal.Duration; // e.g. 1m

0 commit comments

Comments
 (0)