Closed
Conversation
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
| } | ||
| } | ||
|
|
||
| process.on('SIGTERM', () => { |
There was a problem hiding this comment.
Proper fix would be adding error handler to take care of CANCELLED status. Although it is not critical for tutorials but for general javascript SDK client, it should be handled
Contributor
Author
There was a problem hiding this comment.
will take a look. thank you for this
Contributor
There was a problem hiding this comment.
Agreed, it would need a better handling through some error handler kind of mechanism.
Contributor
Author
|
We believe this is not right fix now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This fixes #595 and class of
canceled on clienterrors seen in the workflow API examples.I observed that:
A fixed I used is to:
Issue reference
Please reference the issue this PR will close: #595
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: