Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crates (from CIAO) for I/O + coordinate transforms rather than use astropy.io #3

Open
DougBurke opened this issue Jul 20, 2016 · 5 comments

Comments

@DougBurke
Copy link
Contributor

DougBurke commented Jul 20, 2016

Given that we (edit added for clarification by 'we' I mean the CXC) don't have a good story for all users on installing astropy within CIAO (for various reasons), I'd like to help update the scripts to use the CIAO python I/O library (i.e. crates) rather than astropy.io. Would there be an interest in this?

@darafferty
Copy link
Owner

I think it would be very nice to change the scripts to use crates if that would avoid the issues with CIAO and astropy, and I'd be happy to do so. I guess http://cxc.harvard.edu/ciao/ahelp/crates.html gives the relevant info?

@DougBurke
Copy link
Contributor Author

I'm willing to do the conversion, since I don't think we have good-enough documentation for some of the things used here (e.g. the coordinate transformation parts)- but the changes will need some validation to check I've got the logic right.

@DougBurke
Copy link
Contributor Author

You can see my initial attempts at https://github.com/DougBurke/Xmaps/tree/replace-astropy-by-crates - I had hoped to get to it earlier as I am on vacation starting the 2nd. It's not complete, but is a start (and I fully expect it to fail ...).

@DougBurke
Copy link
Contributor Author

I've now done a "full" conversion on the https://github.com/DougBurke/Xmaps/tree/replace-astropy-by-crates branch. I fully expect it to contain bugs, in particular in how the various coordinate transformations are read in from files and applied (since I haven't been able to test any of this on real data).

Let me know where the problems are, although I'm going to be on holiday Aug 2 - 17th.

@DougBurke
Copy link
Contributor Author

DougBurke commented Jul 29, 2016

The code is available via PR #4 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants