Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #15

Open
barraudf opened this issue Dec 5, 2017 · 4 comments
Open

Suggestions #15

barraudf opened this issue Dec 5, 2017 · 4 comments

Comments

@barraudf
Copy link
Contributor

barraudf commented Dec 5, 2017

Hi,

I'm getting back to work on my old voxel project, and first thing to do is to get it up to date with Unity and MagicaVoxel.

I thought I could work on MagicaVoxelUnity on parallel and get it working again.

Here are a few changes that come to my mind :

  • Remove unused/outdated/not working stuff (shaders, SSAO, alphamask - thinking about it, that was a bad idea).
  • I made a new repository to create a generic C# vox file reader (not dependant on Unity3D). I'm going to use it in my own project, and I could integrate it to MagicaVoxel if you are ok with that, so that upcoming vox format changes are dealt once instead of each project. This shouldn't be hard.
  • Add UV data to meshes so that it can work with Unity Standard Shaders (we can still set vertex color so that anyone can use his own shader) and use MagicaVoxel palettes png as textures.
  • maybe a few other changes

What do you think @darkfall ?

@barraudf
Copy link
Contributor Author

barraudf commented Dec 8, 2017

  • Repository clean up
  • Update the project to Unity 2017.2
  • Add UV data to meshes
  • Render models with Unity's default shader (I still need to work on on the fly texture generation from the model palette)

All this was actually pretty quick. Also, I'll add a tutorial on the wiki about SSAO

@darkfall
Copy link
Owner

@barraudf all these are good ideas! I'll be happy to merge the changes if you would like to.

I think @ephtracy haven't updated the documentation of .vox format as of 0.99a. I've heard he is going to make a plugin system for exporting models, that will make the integration easier : )

@barraudf
Copy link
Contributor Author

@barraudf all these are good ideas! I'll be happy to merge the changes if you would like to.

I may push something tonight.

I think @ephtracy haven't updated the documentation of .vox format as of 0.99a

Yeah, I asked him on twitter, documentation will come later :(

@barraudf
Copy link
Contributor Author

barraudf commented Dec 12, 2017

PR done.

I've not changed anything regarding the vox file reading using my new repository. I may give it a try once documentation is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants