Fix highlights default mode

jenshannoschwalm · TurboGit · commit cd53309ddf81 · 2025-03-24T18:21:16.000+01:00
Test &amp; set correctly in reload_defaults()
diff --git a/src/iop/highlights.c b/src/iop/highlights.c
@@ -1218,7 +1218,6 @@ void reload_defaults(dt_iop_module_t *self)
                                                                    DT_IOP_HIGHLIGHTS_OPPOSED);
       // As we only have clip available we remove all other options
       for(int i = 0; i < 6; i++) dt_bauhaus_combobox_remove_at(g->mode, 1);
-      d->mode = DT_IOP_HIGHLIGHTS_CLIP;
     }
     else if(sraw)
     {
@@ -1237,6 +1236,7 @@ void reload_defaults(dt_iop_module_t *self)
     _set_quads(g, NULL);
   }
   d->clip = MIN(d->clip, img->linear_response_limit);
+  d->mode = rawprep ? DT_IOP_HIGHLIGHTS_OPPOSED : DT_IOP_HIGHLIGHTS_CLIP;
 }
 
 static void _quad_callback(GtkWidget *quad, dt_iop_module_t *self)

Original file line number	Diff line number	Diff line change
`@@ -1218,7 +1218,6 @@ void reload_defaults(dt_iop_module_t *self)`
`1218`	`1218`	`DT_IOP_HIGHLIGHTS_OPPOSED);`
`1219`	`1219`	`// As we only have clip available we remove all other options`
`1220`	`1220`	`for(int i = 0; i < 6; i++) dt_bauhaus_combobox_remove_at(g->mode, 1);`
`1221`		`- d->mode = DT_IOP_HIGHLIGHTS_CLIP;`
`1222`	`1221`	`}`
`1223`	`1222`	`else if(sraw)`
`1224`	`1223`	`{`
`@@ -1237,6 +1236,7 @@ void reload_defaults(dt_iop_module_t *self)`
`1237`	`1236`	`_set_quads(g, NULL);`
`1238`	`1237`	`}`
`1239`	`1238`	`d->clip = MIN(d->clip, img->linear_response_limit);`
	`1239`	`+ d->mode = rawprep ? DT_IOP_HIGHLIGHTS_OPPOSED : DT_IOP_HIGHLIGHTS_CLIP;`
`1240`	`1240`	`}`
`1241`	`1241`
`1242`	`1242`	`static void _quad_callback(GtkWidget quad, dt_iop_module_t self)`