Cleanup.

Author: davidmorgan

build_runner_core/lib/src/asset_graph/graph.dart

@@ -382,6 +382,7 @@ class AssetGraph implements GeneratedAssetHider {
     });
 
     _addSources(newIds);
+
     var newAndModifiedNodes = [
       for (var id in modifyIds.followedBy(newIds)) get(id)!,
     ];
@@ -398,9 +399,8 @@ class AssetGraph implements GeneratedAssetHider {
       digestReader,
     );
 
-    // Collects the set of all transitive ids to be removed from the graph,
-    // based on the removed `SourceAssetNode`s by following the
-    // `primaryOutputs`.
+    // Compute generated nodes that will no longer be output because their
+    // primary input was deleted. Delete them.
     var transitiveRemovedIds = <AssetId>{};
     void addTransitivePrimaryOutputs(AssetId id) {
       if (transitiveRemovedIds.add(id)) {
@@ -414,26 +414,8 @@ class AssetGraph implements GeneratedAssetHider {
         addTransitivePrimaryOutputs(id);
       }
     }
-
-    // The generated nodes to actually delete from the file system.
     var idsToDelete = Set<AssetId>.from(transitiveRemovedIds)
       ..removeAll(removeIds);
-
-    // TODO(davidmorgan): ensure deleted outputs are updated.
-    // We definitely need to update manually deleted outputs.
-    /*for (var deletedOutput in removeIds
-        .map(get)
-        .nonNulls
-        .where((n) => n.type == NodeType.generated)) {
-      updateNode(deletedOutput.id, (nodeBuilder) {
-        nodeBuilder.generatedNodeState.pendingBuildAction =
-            PendingBuildAction.build;
-      });
-    }*/
-
-    _addOutputsForSources(buildPhases, newIds, rootPackage);
-
-    // Delete all the invalidated assets.
     await Future.wait(idsToDelete.map(delete));
 
     // Change deleted source assets and their transitive primary outputs to
@@ -446,6 +428,8 @@ class AssetGraph implements GeneratedAssetHider {
       }
     }
 
+    _addOutputsForSources(buildPhases, newIds, rootPackage);
+
     _outputs = null;
     return idsToDelete;
   }