Skip to content

Commit b481d02

Browse files
authored
Only sky_engine can have _embedder.yaml file. (#2300)
* Only sky_engine can have _embedder.yaml file. * Remove 'solo'.
1 parent b484972 commit b481d02

File tree

8 files changed

+5
-7
lines changed

8 files changed

+5
-7
lines changed

test/dartdoc_test.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -338,14 +338,13 @@ void main() {
338338
});
339339

340340
test('generate docs for package with embedder yaml', () async {
341-
var dartdoc =
342-
await buildDartdoc([], testPackageWithEmbedderYaml, tempDir);
341+
var dartdoc = await buildDartdoc([], testSkyEnginePackage, tempDir);
343342

344343
var results = await dartdoc.generateDocs();
345344
expect(results.packageGraph, isNotNull);
346345

347346
var p = results.packageGraph;
348-
expect(p.defaultPackage.name, 'test_package_embedder_yaml');
347+
expect(p.defaultPackage.name, 'sky_engine');
349348
expect(p.defaultPackage.hasDocumentationFile, isFalse);
350349
expect(p.libraries, hasLength(3));
351350
expect(p.libraries.map((lib) => lib.name).contains('dart:core'), isTrue);
@@ -354,7 +353,7 @@ void main() {
354353
expect(p.packageMap.length, equals(2));
355354
// Things that do not override the core SDK belong in their own package.
356355
expect(p.packageMap['Dart'].isSdk, isTrue);
357-
expect(p.packageMap['test_package_embedder_yaml'].isSdk, isFalse);
356+
expect(p.packageMap['sky_engine'].isSdk, isFalse);
358357
// Should be true once dart-lang/sdk#32707 is fixed.
359358
//expect(
360359
// p.publicLibraries,

test/src/utils.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@ final Directory testPackageExperimentsDir =
7777
Directory('testing/test_package_experiments');
7878
final Directory testPackageMinimumDir =
7979
Directory('testing/test_package_minimum');
80-
final Directory testPackageWithEmbedderYaml =
81-
Directory('testing/test_package_embedder_yaml');
80+
final Directory testSkyEnginePackage = Directory('testing/sky_engine');
8281
final Directory testPackageWithNoReadme =
8382
Directory('testing/test_package_small');
8483
final Directory testPackageIncludeExclude =
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
name: test_package_embedder_yaml
1+
name: sky_engine
22
description: package with embedder yaml
33
version: 0.0.1

0 commit comments

Comments
 (0)