Fix accidental reentrance on TopLevelVariables in rare case (#2173)

jcollins-g · web-flow · commit db5fe1c390f4 · 2020-04-09T08:32:35.000-07:00
diff --git a/lib/src/model/package_graph.dart b/lib/src/model/package_graph.dart
@@ -105,7 +105,7 @@ class PackageGraph {
           yield d.precacheLocalDocs();
           // TopLevelVariables get their documentation from getters and setters,
           // so should be precached if either has a template.
-          if (m is TopLevelVariable) {
+          if (m is TopLevelVariable && !precachedElements.contains(m)) {
             precachedElements.add(m);
             yield m.precacheLocalDocs();
           }

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ class PackageGraph {`
`105`	`105`	`yield d.precacheLocalDocs();`
`106`	`106`	`// TopLevelVariables get their documentation from getters and setters,`
`107`	`107`	`// so should be precached if either has a template.`
`108`		`- if (m is TopLevelVariable) {`
	`108`	`+ if (m is TopLevelVariable && !precachedElements.contains(m)) {`
`109`	`109`	`precachedElements.add(m);`
`110`	`110`	`yield m.precacheLocalDocs();`
`111`	`111`	`}`