Skip to content

Commit e50623b

Browse files
authored
Remove extraneous parens from function-type (#3856)
1 parent 199c7b4 commit e50623b

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

lib/src/render/element_type_renderer.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ abstract class ElementTypeRenderer<T extends ElementType> {
1616
String wrapNullabilityParens(T elementType, String inner) =>
1717
elementType.nullabilitySuffix.isEmpty
1818
? inner
19-
: '($inner${elementType.nullabilitySuffix})';
19+
: '$inner${elementType.nullabilitySuffix}';
2020
}
2121

2222
// HTML implementations.

test/element_type_test.dart

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,11 @@ void f(int Function(String)? p) {}
171171

172172
expect(
173173
parameterType.linkedName,
174-
// TODO(https://github.com/dart-lang/dartdoc/issues/2381): Fix.
175-
'($intLink Function'
174+
'$intLink Function'
176175
'<span class="signature">'
177176
'(<span class="parameter" id="param-">'
178177
'<span class="type-annotation">$stringLink</span>'
179-
'</span>)</span>?)',
178+
'</span>)</span>?',
180179
);
181180
expect(parameterType.nameWithGenerics, equals('Function'));
182181
});
@@ -190,11 +189,11 @@ void f(int Function<T>(T)? p) {}
190189

191190
expect(
192191
parameterType.linkedName,
193-
'($intLink Function'
192+
'$intLink Function'
194193
'&lt;<wbr><span class="type-parameter">T</span>&gt;'
195194
'<span class="signature">'
196195
'(<span class="parameter" id="param-">'
197-
'<span class="type-annotation">T</span></span>)</span>?)',
196+
'<span class="type-annotation">T</span></span>)</span>?',
198197
);
199198
expect(
200199
parameterType.nameWithGenerics,

0 commit comments

Comments
 (0)