Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: widespread no canonical found warnings in dartdoc for flutter #2099

Closed
jcollins-g opened this issue Dec 17, 2019 · 1 comment · Fixed by #2179
Closed

regression: widespread no canonical found warnings in dartdoc for flutter #2099

jcollins-g opened this issue Dec 17, 2019 · 1 comment · Fixed by #2179
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@jcollins-g
Copy link
Contributor

Sometime before 0.29.2 (probably pre 0.29.0 but it is difficult to tell since it's hard to run very old versions of dartdoc now for apples to apples comparisons), flutter docs starting having trouble linking to canonicalModelElements. Many warnings of this type are displayed but there definitely are canonical references so we shouldn't be giving up here.

flutter-docs-original:   warning: no canonical library found for flutter_localizations.GlobalMaterialLocalizations.alertDialogLabel, not linking, from flutter_localizations.GlobalMaterialLocalizations.alertDialogLabe
l: (file:///private/var/folders/b8/jg3_spkj02d51bcz3fsb5jjc000b33/T/dartdoc-comparison-flutter5LTqFQ/packages/flutter/lib/src/material/material_localizations.dart:166:14)
flutter-docs-original:   warning: no canonical library found for flutter_localizations.GlobalMaterialLocalizations.anteMeridiemAbbreviation, not linking, from flutter_localizations.GlobalMaterialLocalizations.anteMer
idiemAbbreviation: (file:///private/var/folders/b8/jg3_spkj02d51bcz3fsb5jjc000b33/T/dartdoc-comparison-flutter5LTqFQ/packages/flutter/lib/src/material/material_localizations.dart:132:14)
flutter-docs-original:   warning: no canonical library found for flutter_localizations.GlobalMaterialLocalizations.backButtonTooltip, not linking, from flutter_localizations.GlobalMaterialLocalizations.backButtonTool
tip: (file:///private/var/folders/b8/jg3_spkj02d51bcz3fsb5jjc000b33/T/dartdoc-comparison-flutter5LTqFQ/packages/flutter/lib/src/material/material_localizations.dart:58:14)
flutter-docs-original:   warning: no canonical library found for flutter_localizations.GlobalMaterialLocalizations.cancelButtonLabel, not linking, from flutter_localizations.GlobalMaterialLocalizations.cancelButtonLa
bel: (file:///private/var/folders/b8/jg3_spkj02d51bcz3fsb5jjc000b33/T/dartdoc-comparison-flutter5LTqFQ/packages/flutter/lib/src/material/material_localizations.dart:105:14)
flutter-docs-original:   warning: no canonical library found for flutter_localizations.GlobalMaterialLocalizations.closeButtonLabel, not linking, from flutter_localizations.GlobalMaterialLocalizations.closeButtonLabe
l: (file:///private/var/folders/b8/jg3_spkj02d51bcz3fsb5jjc000b33/T/dartdoc-comparison-flutter5LTqFQ/packages/flutter/lib/src/material/material_localizations.dart:108:14)
flutter-docs-original:   warning: no canonical library found for flutter_localizations.GlobalMaterialLocalizations.closeButtonTooltip, not linking, from flutter_localizations.GlobalMaterialLocalizations.closeButtonTo
oltip: (file:///private/var/folders/b8/jg3_spkj02d51bcz3fsb5jjc000b33/T/dartdoc-comparison-flutter5LTqFQ/packages/flutter/lib/src/material/material_localizations.dart:61:14)
flutter-docs-original:   warning: no canonical library found for flutter_localizations.GlobalMaterialLocalizations.collapsedIconTapHint, not linking, from flutter_localizations.GlobalMaterialLocalizations.collapsedIc
onTapHint: (file:///private/var/folders/b8/jg3_spkj02d51bcz3fsb5jjc000b33/T/dartdoc-comparison-flutter5LTqFQ/packages/flutter/lib/src/material/material_localizations.dart:310:14)
@jcollins-g jcollins-g added P1 A high priority bug; for example, a single project is unusable or has many test failures customer-flutter Issues originating from important to Flutter P0 A serious issue requiring immediate resolution and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Dec 17, 2019
@jcollins-g jcollins-g added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P0 A serious issue requiring immediate resolution labels Mar 4, 2020
@jcollins-g jcollins-g mentioned this issue Mar 6, 2020
Merged
@jcollins-g
Copy link
Contributor Author

The primary symptom of this will be random dead links where we expect links to work.

@jcollins-g jcollins-g mentioned this issue Apr 13, 2020
Merged
This was referenced Apr 15, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regression in canonicalization from extension methods dart-lang/dartdoc
1 participant
@jcollins-g