Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dartdoc should show nullability of elements when experiment enabled #2210

Closed
4 tasks done
jcollins-g opened this issue May 12, 2020 · 0 comments · Fixed by #2221
Closed
4 tasks done

dartdoc should show nullability of elements when experiment enabled #2210

jcollins-g opened this issue May 12, 2020 · 0 comments · Fixed by #2221
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented May 12, 2020 •
edited
Loading

Currently, while we don't crash, we don't show nullability when the experiment is switched on. If the experiment is enabled and the package is migrated, we should try to show nullable elements with ?.

  • Fields
  • Methods
  • Parameters
  • Type parameters
@jcollins-g jcollins-g added nnbd P1 A high priority bug; for example, a single project is unusable or has many test failures labels May 12, 2020
@jcollins-g jcollins-g mentioned this issue May 12, 2020
Closed
@jcollins-g jcollins-g added the type-enhancement A request for a change that isn't a bug label May 12, 2020
@jcollins-g jcollins-g mentioned this issue May 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine detection for NNBD cases and tag generated pages with "Null safety" dart-lang/dartdoc
1 participant
@jcollins-g