Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dartdoc should allow nnbd ? and ! inside comment references #2212

Closed
jcollins-g opened this issue May 12, 2020 · 4 comments
Closed

dartdoc should allow nnbd ? and ! inside comment references #2212

jcollins-g opened this issue May 12, 2020 · 4 comments
Assignees
@srawlins
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug

Comments

@jcollins-g
Copy link
Contributor

I expect people will write things like [Object?] and possibly even [fieldName!] to refer to elements in comment references. Support this similarly to how we used to strip out 'new' and other extraneous information.
@jcollins-g jcollins-g changed the title dartdoc should allow ? and ! inside comment references dartdoc should allow nnbd ? and ! inside comment references May 12, 2020
@jcollins-g jcollins-g added nnbd P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels May 12, 2020
@mit-mit
Copy link
Member

mit-mit commented Sep 2, 2020

@jcollins-g how is this progressing?

@devoncarew
Copy link
Member

cc @srawlins

@srawlins
Copy link
Member

srawlins commented Sep 2, 2020

I can prioritize this for September.

@srawlins srawlins added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Sep 2, 2020
@srawlins srawlins self-assigned this Sep 2, 2020
@srawlins
Copy link
Member

srawlins commented Sep 5, 2020

Fixed by #2328

@srawlins srawlins closed this as completed Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @devoncarew @mit-mit @jcollins-g