Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart api docs footer should have ability to be dismissed/closed #4013

Closed
1 task
Luckey-Elijah opened this issue Jun 3, 2024 · 3 comments · Fixed by #4014
Closed
1 task

dart api docs footer should have ability to be dismissed/closed #4013

Luckey-Elijah opened this issue Jun 3, 2024 · 3 comments · Fixed by #4014
Assignees
Labels
area-web-design Something a web designer interested in helping could do. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@Luckey-Elijah
Copy link

Describe the problem

When browsing on https://api.dart.dev/, there is a persistent footer. On desktop, the space it occupies is not much, but on mobile the footer takes up much more of the valuable screen space (about 10% - 20% of the entire screen).

Screenshot 2024-06-03 at 3 45 19 PM

Expected fix

I would like a way to

  1. dismiss the footer,
  2. a footer that is not pinned/persistent,
  3. or a smaller footer on the mobile viewports

On which browser(s) did you experience this issue?

Firefox, Safari

Additional context

IMG_F1C10EAC3D61-1

I would like to fix this problem.

  • I will try and fix this problem on dart.dev.
@yashathwani
Copy link

Would like to work on this issue can you assign this to me !!

@parlough parlough removed their assignment Sep 24, 2024
@antfitch antfitch transferred this issue from dart-lang/site-www Mar 5, 2025
@srawlins srawlins added type-enhancement A request for a change that isn't a bug P2 A bug or feature request we're likely to work on area-web-design Something a web designer interested in helping could do. labels Mar 5, 2025
@srawlins
Copy link
Member

srawlins commented Mar 5, 2025

Thanks for filing an issue!

@yashathwani we definitely accept PRs. I don't know what the design of this should be. Or even, honestly whether we can allow the user to close it... Since this is the footer for api.dart.dev, I'd like @athomas 's input for the idea.

Anyways, if you get to prototyping something, or have some ideas, you might want to post them here before working too long on a full implementation.

@athomas
Copy link
Member

athomas commented Mar 5, 2025

My personal preference would be to align the footer closer to dart.dev/'s or pub.dev's footer (the content is already shared).

Note that some of this is in the Dart SDK repo, e.g.:
https://github.com/dart-lang/sdk/blob/main/tools/bots/dartdoc_footer.html

The dart.dev/pub.dev solution where the footer scrolls out of view simplifies things, because some elements need to be present on the page (and we'd have to go through internal reviews to know if we can hide them).

@parlough parlough self-assigned this Mar 10, 2025
srawlins pushed a commit that referenced this issue Mar 25, 2025
Update the site's layout implementation so that the main content can
scroll with the entire viewport rather than having a separate scroll
view. This allows the footer to be placed after the main content rather
than fixed at the bottom and better aligns the site's layout with
dart.dev and docs.flutter.dev.

- Don't limit the body to a height of 100%, so that the main content can
be scrolled as part of the primary/full viewport. This is what allows
the footer to be after the content.
- Make header sticky so they always remain visible at the top of the
viewport.
- Make sidebars sticky, but below the header, so that they remain
visible when scrolling the main content.
- Remove custom webkit scrollbar styles as they cause part of the
header's chrome to go missing and are platform dependent.
- Add `color-scheme: <light or dark>` to the theme styles so the browser
provides properly themed scrollbars.
- Removing these styles also resolves a TODO relating to the mobile
version of the sidebars.

Resolves #4013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-design Something a web designer interested in helping could do. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants