-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart api docs footer should have ability to be dismissed/closed #4013
Comments
Would like to work on this issue can you assign this to me !! |
Thanks for filing an issue! @yashathwani we definitely accept PRs. I don't know what the design of this should be. Or even, honestly whether we can allow the user to close it... Since this is the footer for api.dart.dev, I'd like @athomas 's input for the idea. Anyways, if you get to prototyping something, or have some ideas, you might want to post them here before working too long on a full implementation. |
My personal preference would be to align the footer closer to dart.dev/'s or pub.dev's footer (the content is already shared). Note that some of this is in the Dart SDK repo, e.g.: The dart.dev/pub.dev solution where the footer scrolls out of view simplifies things, because some elements need to be present on the page (and we'd have to go through internal reviews to know if we can hide them). |
Update the site's layout implementation so that the main content can scroll with the entire viewport rather than having a separate scroll view. This allows the footer to be placed after the main content rather than fixed at the bottom and better aligns the site's layout with dart.dev and docs.flutter.dev. - Don't limit the body to a height of 100%, so that the main content can be scrolled as part of the primary/full viewport. This is what allows the footer to be after the content. - Make header sticky so they always remain visible at the top of the viewport. - Make sidebars sticky, but below the header, so that they remain visible when scrolling the main content. - Remove custom webkit scrollbar styles as they cause part of the header's chrome to go missing and are platform dependent. - Add `color-scheme: <light or dark>` to the theme styles so the browser provides properly themed scrollbars. - Removing these styles also resolves a TODO relating to the mobile version of the sidebars. Resolves #4013
Describe the problem
When browsing on https://api.dart.dev/, there is a persistent footer. On desktop, the space it occupies is not much, but on mobile the footer takes up much more of the valuable screen space (about 10% - 20% of the entire screen).
Expected fix
I would like a way to
On which browser(s) did you experience this issue?
Firefox, Safari
Additional context
I would like to fix this problem.
The text was updated successfully, but these errors were encountered: