Skip to content

Commit 5527a8f

Browse files
authored
remove some errors around abstract and external varaibles (#4023)
1 parent 4e583e5 commit 5527a8f

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

working/augmentation-libraries/feature-specification.md

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -722,11 +722,9 @@ It is a **compile-time error** if:
722722
const variable be augmented by another const variable, changing its value,
723723
or is that too weird?)**
724724

725-
* An `abstract` variable is augmented with a non-abstract variable, getter,
726-
or setter.
725+
* An `abstract` variable is augmented with a non-abstract variable.
727726

728-
* An `external` declaration is augmented with an `abstract` declaration. For
729-
variables this also applies to the implicit getter and setter.
727+
* An `external` variable is augmented with an `abstract` variable.
730728

731729
### Augmenting enum values
732730

@@ -1199,9 +1197,6 @@ declaration ::= 'external' factoryConstructorSignature
11991197

12001198
It is a compile-time error if:
12011199

1202-
* A function, getter, setter, or operator declaration marked `augment` is also
1203-
abstract. **(TODO: Remove. This can be used to add metadata.)**
1204-
12051200
* A declaration marked `augment` is also marked `external`. **(TODO: Probably
12061201
remove for functions, so change to "A variable declaration". A macro should
12071202
be able to implement a method as an external with a `@JS()` annotation.)**
@@ -1399,6 +1394,15 @@ to the augmentation.
13991394

14001395
## Changelog
14011396

1397+
### 1.34
1398+
1399+
* Revert some errors introduced in version 1.28.
1400+
1401+
* An abstract variable can now be augmented with non-abstract getters and
1402+
setters.
1403+
* External variables can now be augmented with abstract getters and
1404+
setters.
1405+
14021406
### 1.33
14031407

14041408
* Change the grammar to remove the primary constructor parts of an

0 commit comments

Comments
 (0)