[analyzer/ffi] Fix crash in ffi_verifier

Fixes a crash in the analyzer that was exercised via dartdoc in
https://dart-review.googlesource.com/c/sdk/+/342763.

Landing the analyzer fix separately, so that it can be rolled first.

Bug: #54754
Change-Id: I40375374cb785c11e3f0b2f21a8a2c74b8f080c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349240
Commit-Queue: Brian Wilkerson <[email protected]>
Auto-Submit: Daco Harkes <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: dcharkes

pkg/analyzer/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 6.4.1
+* Patch for crash in ffi_verifier.
+
 ## 6.3.0
 * Updated the current language version to `3.3`.
 * Removed generated `ConstantEvaluator`.

pkg/analyzer/lib/src/generated/ffi_verifier.dart

@@ -1625,7 +1625,7 @@ class FfiVerifier extends RecursiveAstVisitor<void> {
   /// Validate the invocation of the extension method
   /// `Pointer<T extends Struct>.ref`.
   void _validateRefPrefixedIdentifier(PrefixedIdentifier node) {
-    var targetType = node.prefix.typeOrThrow;
+    var targetType = node.prefix.staticType;
     if (!_isValidFfiNativeType(targetType,
         allowVoid: false, allowEmptyStruct: true)) {
       final AstNode errorNode = node;

pkg/analyzer/pubspec.yaml

@@ -1,5 +1,5 @@
 name: analyzer
-version: 6.4.0
+version: 6.4.1
 description: >-
   This package provides a library that performs static analysis of Dart code.
 repository: https://github.com/dart-lang/sdk/tree/main/pkg/analyzer