[macros] Add language test for introspection cycle.

Small changes so it passes on the analyzer, the CFE does not yet detect cycles.

[email protected], [email protected]

Change-Id: Iaeb586da7066e50b5b90c9793bc34b51e0eabbbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345062
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Jake Macdonald <[email protected]>
Auto-Submit: Morgan :) <[email protected]>
Commit-Queue: Morgan :) <[email protected]>

Author: davidmorgan

pkg/analyzer/lib/src/summary2/macro_application.dart

@@ -280,7 +280,8 @@ class LibraryMacroApplier {
             _elementToIntrospectionCycleId[element] = id;
           }
 
-          throw StateError('[$id] Declarations phase introspection cycle.');
+          throw macro.MacroIntrospectionCycleExceptionImpl(
+              '[$id] Declarations phase introspection cycle.');
         }
       }
     }
@@ -1050,7 +1051,8 @@ class _DeclarationPhaseIntrospector extends _TypePhaseIntrospector
     // We might have detected a cycle for this target element.
     // Either just now, or before.
     if (applier._elementToIntrospectionCycleId[element] case var id?) {
-      throw StateError('[$id] Declarations phase introspection cycle.');
+      throw macro.MacroIntrospectionCycleExceptionImpl(
+          '[$id] Declarations phase introspection cycle.');
     }
   }
 }

tests/language/macros/introspect/declaration_introspect_cycle_failure_test.dart

@@ -0,0 +1,26 @@
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+// SharedOptions=--enable-experiment=macros
+
+import 'impl/assert_in_declarations_phase_macro.dart';
+
+@AssertInDeclarationsPhase(
+  targetName: 'B',
+  constructorsOf: ['b()'],
+  expectThrowsA: 'MacroIntrospectionCycleExceptionImpl',
+)
+class A {
+  A.a();
+}
+
+@AssertInDeclarationsPhase(
+  targetName: 'A',
+  constructorsOf: ['a()'],
+  expectThrowsA: 'MacroIntrospectionCycleExceptionImpl',
+)
+class B {
+  B.b();
+}
+
+void main() {}

tests/language/macros/introspect/failure_test.dart

@@ -11,24 +11,25 @@ import 'impl/assert_in_types_phase_macro.dart';
 // pass with a false positive. This test should start failing at the same time.
 
 @AssertInTypesPhase(
-// [error line 13, column 1, length 218]
-// [analyzer] COMPILE_TIME_ERROR.MACRO_ERROR
+// [error line 13, column 1]
+// [analyzer] unspecified
+// [cfe] unspecified
   targetLibrary: 'dart:core',
   targetName: 'int',
   resolveIdentifier: '<intentional mismatch and failure>',
 )
 @AssertInDefinitionsPhase(
-// [error line 20, column 1, length 191]
-// [analyzer] COMPILE_TIME_ERROR.MACRO_ERROR
+// [error line 21, column 1]
+// [analyzer] unspecified
+// [cfe] unspecified
   targetName: 'A',
   constructorsOf: ['<intentional mismatch and failure>'],
 )
 @AssertInDeclarationsPhase(
-// [error line 26, column 1, length 191]
-// [analyzer] COMPILE_TIME_ERROR.MACRO_ERROR
+// [error line 28, column 1]
+// [analyzer] unspecified
+// [cfe] unspecified
   targetName: 'A',
   constructorsOf: ['<intentional mismatch and failure'],
 )
 class A {}
-
-// TODO(davidmorgan): add CFE error coverage.

tests/language/macros/introspect/impl/assert_in_declarations_phase_macro.dart

@@ -9,25 +9,34 @@ import 'package:expect/expect.dart';
 
 import 'impl.dart';
 
-macro class AssertInDeclarationsPhase
-    implements ClassDeclarationsMacro {
+macro class AssertInDeclarationsPhase implements ClassDeclarationsMacro {
   final String? targetLibrary;
   final String targetName;
   final List? constructorsOf;
   final List? fieldsOf;
   final List? methodsOf;
+  final String? expectThrowsA;
 
   const AssertInDeclarationsPhase(
       {this.targetLibrary,
       required this.targetName,
       this.constructorsOf,
       this.fieldsOf,
-      this.methodsOf});
+      this.methodsOf,
+      this.expectThrowsA});
 
   @override
   Future<void> buildDeclarationsForClass(
-          ClassDeclaration clazz, MemberDeclarationBuilder builder) =>
-      _assert(clazz, builder);
+      ClassDeclaration clazz, MemberDeclarationBuilder builder) async {
+    Object? thrown;
+    try {
+      await _assert(clazz, builder);
+      thrown = null;
+    } catch (e) {
+      thrown = e;
+    }
+    Expect.equals(expectThrowsA, thrown?.runtimeType.toString());
+  }
 
   // TODO(davidmorgan): support asserting in more places.