[analyzer/linter] Mark a few diagnostic docs as published

Also regenerate the diagnostic codes and (deprecated) lint rules.json file.

Change-Id: Id50dfe81a7bc3a62fee9d6b99f0e045804e95685
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/436960
Commit-Queue: Keerti Parthasarathy <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>

Author: parlough

pkg/analyzer/lib/src/error/codes.g.dart

@@ -1396,6 +1396,7 @@ class CompileTimeErrorCode extends DiagnosticCode {
       CompileTimeErrorCode(
         'DOT_SHORTHAND_MISSING_CONTEXT',
         "A dot shorthand can't be used where there is no context type.",
+        hasPublishedDocs: true,
       );
 
   ///  Parameters:
@@ -1408,6 +1409,7 @@ class CompileTimeErrorCode extends DiagnosticCode {
     correctionMessage:
         "Try correcting the name to the name of an existing static getter, or "
         "defining a getter or field named '{0}'.",
+    hasPublishedDocs: true,
     uniqueName: 'DOT_SHORTHAND_UNDEFINED_GETTER',
   );
 
@@ -1422,6 +1424,7 @@ class CompileTimeErrorCode extends DiagnosticCode {
     correctionMessage:
         "Try correcting the name to the name of an existing static method or "
         "constructor, or defining a static method or constructor named '{0}'.",
+    hasPublishedDocs: true,
     uniqueName: 'DOT_SHORTHAND_UNDEFINED_INVOCATION',
   );
 
@@ -6506,24 +6509,28 @@ class WarningCode extends DiagnosticCode {
     'DOC_IMPORT_CANNOT_BE_DEFERRED',
     "Doc imports can't be deferred.",
     correctionMessage: "Try removing the 'deferred' keyword.",
+    hasPublishedDocs: true,
   );
 
   static const WarningCode DOC_IMPORT_CANNOT_HAVE_COMBINATORS = WarningCode(
     'DOC_IMPORT_CANNOT_HAVE_COMBINATORS',
     "Doc imports can't have show or hide combinators.",
     correctionMessage: "Try removing the combinator.",
+    hasPublishedDocs: true,
   );
 
   static const WarningCode DOC_IMPORT_CANNOT_HAVE_CONFIGURATIONS = WarningCode(
     'DOC_IMPORT_CANNOT_HAVE_CONFIGURATIONS',
     "Doc imports can't have configurations.",
     correctionMessage: "Try removing the configurations.",
+    hasPublishedDocs: true,
   );
 
   static const WarningCode DOC_IMPORT_CANNOT_HAVE_PREFIX = WarningCode(
     'DOC_IMPORT_CANNOT_HAVE_PREFIX',
     "Doc imports can't have prefixes.",
     correctionMessage: "Try removing the prefix.",
+    hasPublishedDocs: true,
   );
 
   ///  Duplicate exports.
@@ -6895,6 +6902,7 @@ class WarningCode extends DiagnosticCode {
     "The annotation '@reopen' can only be applied to a class that opens "
         "capabilities that the supertype intentionally disallows.",
     correctionMessage: "Try removing the '@reopen' annotation.",
+    hasPublishedDocs: true,
   );
 
   ///  This warning is generated anywhere where `@required` annotates a named
@@ -6961,6 +6969,7 @@ class WarningCode extends DiagnosticCode {
     'INVALID_USE_OF_PROTECTED_MEMBER',
     "The member '{0}' can only be used within instance members of subclasses "
         "of '{1}'.",
+    hasPublishedDocs: true,
   );
 
   ///  Parameters:
@@ -7197,6 +7206,7 @@ class WarningCode extends DiagnosticCode {
     'NON_NULLABLE_EQUALS_PARAMETER',
     "The parameter type of '==' operators should be non-nullable.",
     correctionMessage: "Try using a non-nullable type.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.
@@ -7651,6 +7661,7 @@ class WarningCode extends DiagnosticCode {
     'UNNECESSARY_WILDCARD_PATTERN',
     "Unnecessary wildcard pattern.",
     correctionMessage: "Try removing the wildcard pattern.",
+    hasPublishedDocs: true,
   );
 
   ///  No parameters.

pkg/analyzer/messages.yaml

@@ -3878,7 +3878,7 @@ CompileTimeErrorCode:
   DOT_SHORTHAND_MISSING_CONTEXT:
     experiment: dot-shorthands
     problemMessage: "A dot shorthand can't be used where there is no context type."
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     documentation: |-
       #### Description
 
@@ -3929,7 +3929,7 @@ CompileTimeErrorCode:
     experiment: dot-shorthands
     problemMessage: "The static getter '{0}' isn't defined for the context type '{1}'."
     correctionMessage: "Try correcting the name to the name of an existing static getter, or defining a getter or field named '{0}'."
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     comment: |-
       Parameters:
       0: the name of the static getter
@@ -3984,7 +3984,7 @@ CompileTimeErrorCode:
     experiment: dot-shorthands
     problemMessage: "The static method or constructor '{0}' isn't defined for the context type '{1}'."
     correctionMessage: "Try correcting the name to the name of an existing static method or constructor, or defining a static method or constructor named '{0}'."
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     comment: |-
       Parameters:
       0: the name of the static method or constructor
@@ -24143,7 +24143,7 @@ WarningCode:
   DOC_IMPORT_CANNOT_BE_DEFERRED:
     problemMessage: "Doc imports can't be deferred."
     correctionMessage: Try removing the 'deferred' keyword.
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     documentation: |-
       #### Description
 
@@ -24175,7 +24175,7 @@ WarningCode:
   DOC_IMPORT_CANNOT_HAVE_COMBINATORS:
     problemMessage: "Doc imports can't have show or hide combinators."
     correctionMessage: Try removing the combinator.
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     documentation: |-
       #### Description
 
@@ -24205,7 +24205,7 @@ WarningCode:
   DOC_IMPORT_CANNOT_HAVE_CONFIGURATIONS:
     problemMessage: "Doc imports can't have configurations."
     correctionMessage: Try removing the configurations.
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     documentation: |-
       #### Description
 
@@ -24235,7 +24235,7 @@ WarningCode:
   DOC_IMPORT_CANNOT_HAVE_PREFIX:
     problemMessage: "Doc imports can't have prefixes."
     correctionMessage: Try removing the prefix.
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     documentation: |-
       #### Description
 
@@ -25338,7 +25338,7 @@ WarningCode:
       Remove the reference to the internal declaration.
   INVALID_USE_OF_PROTECTED_MEMBER:
     problemMessage: "The member '{0}' can only be used within instance members of subclasses of '{1}'."
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     comment: |-
       This warning is generated anywhere where a member annotated with
       `@protected` is used outside of an instance member of a subclass.
@@ -25356,7 +25356,7 @@ WarningCode:
 
       #### Example
 
-      Given a file `a.dart` that contains
+      Given a file `a.dart` that contains the following:
 
       ```dart
       %uri="lib/a.dart"
@@ -25719,7 +25719,7 @@ WarningCode:
   INVALID_REOPEN_ANNOTATION:
     problemMessage: "The annotation '@reopen' can only be applied to a class that opens capabilities that the supertype intentionally disallows."
     correctionMessage: Try removing the '@reopen' annotation.
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     comment: |-
       This warning is generated anywhere where `@reopen` annotates a class which
       did not reopen any type.
@@ -26416,7 +26416,7 @@ WarningCode:
   NON_NULLABLE_EQUALS_PARAMETER:
     problemMessage: "The parameter type of '==' operators should be non-nullable."
     correctionMessage: Try using a non-nullable type.
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description
@@ -28157,7 +28157,7 @@ WarningCode:
   UNNECESSARY_WILDCARD_PATTERN:
     problemMessage: Unnecessary wildcard pattern.
     correctionMessage: Try removing the wildcard pattern.
-    hasPublishedDocs: false
+    hasPublishedDocs: true
     comment: No parameters.
     documentation: |-
       #### Description

pkg/linter/CHANGELOG.md

@@ -1,4 +1,6 @@
-# 3.9.0-wip
+# 3.10.0-wip
+
+# 3.9.0
 
 - new lint: `switch_on_type`
 - new lint: `unnecessary_unawaited`

pkg/linter/tool/machine/rules.json

@@ -1574,7 +1574,8 @@
     ],
     "state": "experimental",
     "incompatible": [
-      "always_specify_types"
+      "always_specify_types",
+      "type_annotate_public_apis"
     ],
     "sets": [],
     "fixStatus": "hasFix",
@@ -2510,7 +2511,9 @@
       "publicInterface"
     ],
     "state": "stable",
-    "incompatible": [],
+    "incompatible": [
+      "omit_obvious_property_types"
+    ],
     "sets": [],
     "fixStatus": "hasFix",
     "details": "From [Effective Dart](https://dart.dev/effective-dart/design#do-type-annotate-fields-and-top-level-variables-if-the-type-isnt-obvious):\n\n**PREFER** type annotating public APIs.\n\nType annotations are important documentation for how a library should be used.\nAnnotating the parameter and return types of public methods and functions helps\nusers understand what the API expects and what it provides.\n\nNote that if a public API accepts a range of values that Dart's type system\ncannot express, then it is acceptable to leave that untyped.  In that case, the\nimplicit `dynamic` is the correct type for the API.\n\nFor code internal to a library (either private, or things like nested functions)\nannotate where you feel it helps, but don't feel that you *must* provide them.\n\n**BAD:**\n```dart\ninstall(id, destination) {\n  // ...\n}\n```\n\nHere, it's unclear what `id` is.  A string? And what is `destination`? A string\nor a `File` object? Is this method synchronous or asynchronous?\n\n**GOOD:**\n```dart\nFuture<bool> install(PackageId id, String destination) {\n  // ...\n}\n```\n\nWith types, all of this is clarified.",
@@ -2578,7 +2581,7 @@
     "state": "experimental",
     "incompatible": [],
     "sets": [],
-    "fixStatus": "needsFix",
+    "fixStatus": "hasFix",
     "details": "Functions that don't do `await` don't have to be `async`.\n\nUsually such functions also don't have to return a `Future`, which allows\nan invoker to avoid `await` in its code, etc. Synchronous code in\ngeneral runs faster, and is easier to reason about.\n\n**BAD:**\n```dart\nvoid f() async {\n  // await Future.delayed(const Duration(seconds: 2));\n  print(0);\n}\n```\n\n**GOOD:**\n```dart\nvoid f() {\n  // await Future.delayed(const Duration(seconds: 2));\n  print(0);\n}\n```",
     "sinceDartSdk": "3.7"
   },