Skip to content

Commit 884a48c

Browse files
nshahanCommit Queue
authored andcommitted
[ddc] Delete macro options and cli arguments
Change-Id: I83bd63f707758e82ac23a80b7442d57746f6b125 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/436941 Reviewed-by: Mark Zhou <[email protected]> Commit-Queue: Nicholas Shahan <[email protected]>
1 parent 9270f0f commit 884a48c

File tree

1 file changed

+0
-30
lines changed

1 file changed

+0
-30
lines changed

pkg/dev_compiler/lib/src/command/options.dart

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -100,15 +100,6 @@ class Options {
100100
/// Whether the compiler is generating a dynamic module.
101101
final bool dynamicModule;
102102

103-
/// Raw precompiled macro options, each of the format
104-
/// `<program-uri>;<macro-library-uri>`.
105-
///
106-
/// Multiple library URIs may be provided separated by additional semicolons.
107-
final List<String> precompiledMacros;
108-
109-
/// The serialization mode to use for macro communication.
110-
final String? macroSerializationMode;
111-
112103
Options({
113104
this.sourceMap = true,
114105
this.inlineSourceMap = false,
@@ -129,8 +120,6 @@ class Options {
129120
this.experiments = const {},
130121
this.canaryFeatures = false,
131122
this.dynamicModule = false,
132-
this.precompiledMacros = const [],
133-
this.macroSerializationMode,
134123
}) : emitLibraryBundle =
135124
canaryFeatures &&
136125
moduleFormats.length == 1 &&
@@ -165,8 +154,6 @@ class Options {
165154
),
166155
canaryFeatures: args['canary'] as bool,
167156
dynamicModule: args['dynamic-module'] as bool,
168-
precompiledMacros: args['precompiled-macro'] as List<String>,
169-
macroSerializationMode: args['macro-serialization-mode'] as String?,
170157
);
171158

172159
Options.fromSdkRequiredArguments(ArgResults args)
@@ -282,23 +269,6 @@ class Options {
282269
'checks.',
283270
hide: true,
284271
)
285-
..addMultiOption(
286-
'precompiled-macro',
287-
help:
288-
'Configuration for precompiled macro binaries or kernel files.\n'
289-
'The expected format of this option is as follows: '
290-
'<absolute-path-to-binary>;<macro-library-uri>\nFor example: '
291-
'--precompiled-macro="/path/to/compiled/macro;'
292-
'package:some_macro/some_macro.dart". Multiple library uris may be '
293-
'passed as well (separated by semicolons).',
294-
hide: true,
295-
)
296-
..addOption(
297-
'macro-serialization-mode',
298-
help: 'The serialization mode for communicating with macros.',
299-
allowed: ['bytedata', 'json'],
300-
defaultsTo: 'bytedata',
301-
)
302272
..addFlag(
303273
'dynamic-module',
304274
help: 'Compile to generate a dynamic module',

0 commit comments

Comments
 (0)