Skip to content

Clarify that .name can be used on enum values in the API docs #54679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hixie opened this issue Jan 19, 2024 · 3 comments
Closed

Clarify that .name can be used on enum values in the API docs #54679

Hixie opened this issue Jan 19, 2024 · 3 comments
Labels
area-documentation Prefer using 'type-documentation' and a specific area label. type-documentation A request to add or improve documentation

Comments

@Hixie
Copy link
Contributor

Hixie commented Jan 19, 2024

I keep forgetting you can use .name because the only sign that it exists in the Enum documentation is the in-passing mention that Enum has an extension, without mentioning why. It would be nice for the docs to be clearer.

I tried submitting a PR to fix this but after more than five months of trying to get it landed I gave up.

@a-siva a-siva added area-documentation Prefer using 'type-documentation' and a specific area label. type-documentation A request to add or improve documentation labels Jan 19, 2024
@a-siva
Copy link
Contributor

a-siva commented Jan 19, 2024

I tried submitting a PR to fix this but after more than five months of trying to get it landed I gave up.

Looks like @lrhn reviewed and approved the CL, why not land it?

@Hixie
Copy link
Contributor Author

Hixie commented Jan 19, 2024

Looks like @lrhn reviewed and approved the CL, why not land it?

I have no idea (I don't have commit access so it's not up to me).

@parlough
Copy link
Member

Fix landed in 64b03d1, thanks @Hixie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Prefer using 'type-documentation' and a specific area label. type-documentation A request to add or improve documentation
Projects
None yet
Development

No branches or pull requests

3 participants