Skip to content

Commit d65ea4d

Browse files
committed
Try removing isolate.kill()
At one point isolates were killed when the loader was closed as the runner is shutting down. Later the kill was moved to when the test suite is done. There was no specific comment about the `isolate.kill()` changes. https://codereview.chromium.org//1206033004 Before that the `isolate.kill` on close goes back to the original implementation of the loader. https://codereview.chromium.org//920703006 No internal tests seem to be relying on this behavior, and nothing times out when it is removed. Check whether there are any tests on CI that validate this behavior.
1 parent 6a4e75a commit d65ea4d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

pkgs/test_core/lib/src/runner/vm/platform.dart

-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ class VMPlatform extends PlatformPlugin {
8080
rethrow;
8181
}
8282
outerChannel = MultiChannel(IsolateChannel.connectReceive(receivePort));
83-
cleanupCallbacks.add(isolate.kill);
8483
}
8584
cleanupCallbacks.add(outerChannel.sink.close);
8685

0 commit comments

Comments
 (0)