Skip to content

Commit 697f2f7

Browse files
authored
renamed DWDS injector parameter (#2602)
1 parent af33df7 commit 697f2f7

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

dwds/CHANGELOG.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
## 24.3.9-wip
1+
## 24.3.9
2+
3+
- Renamed DWDS Injector parameter `enableDebuggingSupport` to `injectDebuggingSupportCode` for clearer intent.
24

35
## 24.3.8
46

dwds/lib/dart_web_debug_service.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class Dwds {
6666
required Stream<BuildResult> buildResults,
6767
required ConnectionProvider chromeConnection,
6868
required ToolConfiguration toolConfiguration,
69-
bool enableDebuggingSupport = true,
69+
bool injectDebuggingSupportCode = true,
7070
}) async {
7171
globalToolConfiguration = toolConfiguration;
7272
final debugSettings = toolConfiguration.debugSettings;
@@ -120,7 +120,7 @@ class Dwds {
120120

121121
final injected = DwdsInjector(
122122
extensionUri: extensionUri,
123-
enableDebuggingSupport: enableDebuggingSupport,
123+
injectDebuggingSupportCode: injectDebuggingSupportCode,
124124
);
125125

126126
final devHandler = DevHandler(

dwds/lib/src/handlers/injector.dart

+5-5
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const _clientScript = 'dwds/src/injected/client';
3030
/// to include the injected DWDS client, enabling debugging capabilities
3131
/// and source mapping when running in a browser environment.
3232
///
33-
/// The `_enableDebuggingSupport` flag determines whether debugging-related
33+
/// The `_injectDebuggingSupportCode` flag determines whether debugging-related
3434
/// functionality should be included:
3535
/// - When `true`, the DWDS client is injected, enabling debugging features.
3636
/// - When `false`, debugging support is disabled, meaning the application will
@@ -42,13 +42,13 @@ class DwdsInjector {
4242
final Future<String>? _extensionUri;
4343
final _devHandlerPaths = StreamController<String>();
4444
final _logger = Logger('DwdsInjector');
45-
final bool _enableDebuggingSupport;
45+
final bool _injectDebuggingSupportCode;
4646

4747
DwdsInjector({
4848
Future<String>? extensionUri,
49-
bool enableDebuggingSupport = true,
49+
bool injectDebuggingSupportCode = true,
5050
}) : _extensionUri = extensionUri,
51-
_enableDebuggingSupport = enableDebuggingSupport;
51+
_injectDebuggingSupportCode = injectDebuggingSupportCode;
5252

5353
/// Returns the embedded dev handler paths.
5454
///
@@ -112,7 +112,7 @@ class DwdsInjector {
112112
);
113113
// If true, inject the debugging client and hoist the main function
114114
// to enable debugging support.
115-
if (_enableDebuggingSupport) {
115+
if (_injectDebuggingSupportCode) {
116116
body = await _injectClientAndHoistMain(
117117
body,
118118
appId,

dwds/lib/src/version.dart

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: dwds
22
# Every time this changes you need to run `dart run build_runner build`.
3-
version: 24.3.9-wip
3+
version: 24.3.9
44
description: >-
55
A service that proxies between the Chrome debug protocol and the Dart VM
66
service protocol.

0 commit comments

Comments
 (0)