Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update development tooling and prepare a good workflow #14

Open
4 tasks done
cwadrupldijjit opened this issue Mar 26, 2017 · 0 comments
Open
4 tasks done

Update development tooling and prepare a good workflow #14

cwadrupldijjit opened this issue Mar 26, 2017 · 0 comments
Assignees
@cwadrupldijjit
Labels
enhancement
Milestone
GitHub sign-in flow

Comments

@cwadrupldijjit
Copy link
Contributor

cwadrupldijjit commented Mar 26, 2017 •
edited
Loading

Estimated Hours to Complete: 2

Total Hours to Complete: 8

User Story:

As a Developer,
I want to make the codebase more manageable
so that the development experience can be smoother.

Requirements:

This issue is considered done when:

  • The .eslintrc is modified so as to not restrict come good practices that are preventing the code from staying consitent.
  • Components follow the updated practices outlined as rules in the .eslintrc file.
  • Understanding of the development workflow has been established.
  • Issues are generated and used as a means to show current work, upcoming work, and completed work.

Additional Information:

As I was reviewing the current code, I happened on many files which were showing errors based off of the eslint configuration. For instance, the file components/SiteSidebar/index.jsx alone had 36 errors registered due to violations of the rules outlined in the .eslintrc file in the root of the project. In an effort to clear the error console, work needs to be done on the tooling to get it to work as we'd like it to.
@cwadrupldijjit cwadrupldijjit self-assigned this Mar 30, 2017
@cwadrupldijjit cwadrupldijjit added this to the GitHub sign-in flow milestone Apr 4, 2017
cwadrupldijjit pushed a commit to cwadrupldijjit/dashcommunity-blog that referenced this issue Apr 6, 2017
fix(general): update code for eslint conformance
2366e94 
changes:
  - .babelrc
    - fix quote types to make it conformant JSON
  - .eslintrc
    - update linter to not show errors where errors shouldn't be shown
  - .gitignore
    - begin ignoring the public directory--rely on built code
  - ComposeForm/*
    - beginnings of splitting up FormElements.jsx (will be addressed later)
  - PrefixedLink/index.jsx
    - add component to automatically prefix links in order to avoid having to do it manually
  - gatsby-node.js,
        ComposePage/index.jsx,
        Editor/index.jsx,
        FormElements.jsx,
        GitHubForm.jsx,
        gitHubHelper.js,
        localStorageHelper.js,
        ReadNext/index.jsx,
        SiteLinks/index.jsx,
        SiteNav/index.jsx,
        SitePage/index.jsx,
        SitePost/index.jsx,
        SiteSidebar/index.jsx
    - update files to eslint compliance
    - change repetetive field/element creation into data transformed the way you want
  - public/*
    - remove from git (built)

issues addressed:
  - dashcommunity#14

no breaking changes--UI works exactly as originally implemented
@cwadrupldijjit cwadrupldijjit mentioned this issue Apr 6, 2017
Closed
riongull pushed a commit that referenced this issue May 5, 2017
@cwadrupldijjit @riongull
[PLEASE REVIEW] #17 Auto submit token (#21)
c4e0d10 
* fix(general): update code for eslint conformance

changes:
  - .babelrc
    - fix quote types to make it conformant JSON
  - .eslintrc
    - update linter to not show errors where errors shouldn't be shown
  - .gitignore
    - begin ignoring the public directory--rely on built code
  - ComposeForm/*
    - beginnings of splitting up FormElements.jsx (will be addressed later)
  - PrefixedLink/index.jsx
    - add component to automatically prefix links in order to avoid having to do it manually
  - gatsby-node.js,
        ComposePage/index.jsx,
        Editor/index.jsx,
        FormElements.jsx,
        GitHubForm.jsx,
        gitHubHelper.js,
        localStorageHelper.js,
        ReadNext/index.jsx,
        SiteLinks/index.jsx,
        SiteNav/index.jsx,
        SitePage/index.jsx,
        SitePost/index.jsx,
        SiteSidebar/index.jsx
    - update files to eslint compliance
    - change repetetive field/element creation into data transformed the way you want
  - public/*
    - remove from git (built)

issues addressed:
  - #14

no breaking changes--UI works exactly as originally implemented

* feat(auth): add firebase auth to site

changes:
  - firebaseHelper.js
    - add helper to manage auth
  - index.jsx
    - create module file to import and export necessary components
  - initializeFirebase.js
    - add file to create the firebase connection
  - gitHubHelpers.js
    - import auth into file to test if it wiill work

issues addressed:
  - #15

no breaking changes; auth not yet fully integrated into the project

* feat(login-button): require login on form

changes:
  - firebaseHelper.js
    - assign token, user, and credential to auth object
    - add to local storage
    - add getAuthObj function to get and deserialize authObj
  - ComposePage/index.jsx
    - import newly created login button and add logic to change whether it shows the action form or if it shows the login button
  - ComposeFormElements/index.jsx
    - add new login button component to exports
  - login-button.css
    - add styles to make sure that it looks non-gaggy
  - LoginButton.jsx
    - create form where the login button will live and call submit function when login is successful
  - package.json
    - ensure that the browser opens to localhost (so firebase auth will work)

issues addressed:
  - #16

no breaking changes--only adds annoyance to the form, not convenience so far

* feat(github): remove token from fields and autofill

changes:
  - add helper functions to deal with username
  - firebase auth helper uses authObj instead of exporting individual members
  - clean up slightly the form elements
  - add username prepopulation to the redux form (dosn't work at the moment)
  - automatically grab the token when submitting the form

issues addressed:
  - #17

no breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwadrupldijjit cwadrupldijjit

Labels
enhancement
Projects
None yet
Milestone
GitHub sign-in flow
Development

No branches or pull requests
1 participant
@cwadrupldijjit