refactor: remove redundant preview and simplify font handling

- Remove moneyFont_preview label from appearance dialog since Overview
  page now shows live preview
- Remove updateMoneyPreview() slot and related signal connections
- Simplify setupFontOptions() to remove preview parameter
- Remove moneyFont_preview from vecIgnoreObjects in guiutil_font.cpp
- Simplify getFontForChoice() by removing unused weight/size settings
  since callers only use the font family (weight and size are overridden
  by setMonospacedFont())
- Use g_font_registry.GetFont() directly for ApplicationFont case
- Set consistent width (282px) for moneyFont combobox to match other
  comboboxes in the dialog

Author: UdjinM6

src/qt/appearancewidget.cpp

@@ -42,7 +42,7 @@ int setFontChoice(QComboBox* cb, const OptionsModel::FontChoice& fc)
     return i;
 }
 
-void setupFontOptions(QComboBox* cb, QLabel* preview)
+void setupFontOptions(QComboBox* cb)
 {
     QFont embedded_font{GUIUtil::fixedPitchFont(true)};
     QFont system_font{GUIUtil::fixedPitchFont(false)};
@@ -51,24 +51,21 @@ void setupFontOptions(QComboBox* cb, QLabel* preview)
     cb->addItem(QObject::tr("Use existing font"), QVariant::fromValue(OptionsModel::FontChoice{OptionsModel::FontChoiceAbstract::ApplicationFont}));
     cb->addItem(QObject::tr("Custom…"));
 
-    const auto& on_font_choice_changed = [cb, preview](int index) {
+    const auto& on_font_choice_changed = [cb](int index) {
         static int previous_index = -1;
         QVariant item_data = cb->itemData(index);
-        QFont f;
         if (item_data.canConvert<OptionsModel::FontChoice>()) {
-            f = OptionsModel::getFontForChoice(item_data.value<OptionsModel::FontChoice>());
+            // Valid predefined choice, nothing to do
         } else {
+            // "Custom..." was selected, show font dialog
             bool ok;
-            f = QFontDialog::getFont(&ok, GUIUtil::fixedPitchFont(false), cb->parentWidget());
+            QFont f = QFontDialog::getFont(&ok, GUIUtil::fixedPitchFont(false), cb->parentWidget());
             if (!ok) {
                 cb->setCurrentIndex(previous_index);
                 return;
             }
             index = setFontChoice(cb, OptionsModel::FontChoice{f});
         }
-        if (preview) {
-            preview->setFont(f);
-        }
         previous_index = index;
     };
     QObject::connect(cb, QOverload<int>::of(&QComboBox::currentIndexChanged), on_font_choice_changed);
@@ -101,18 +98,16 @@ AppearanceWidget::AppearanceWidget(QWidget* parent) :
     mapper->setSubmitPolicy(QDataWidgetMapper::ManualSubmit);
     mapper->setOrientation(Qt::Vertical);
 
-    setupFontOptions(ui->moneyFont, ui->moneyFont_preview);
+    setupFontOptions(ui->moneyFont);
 
     connect(ui->fontFamily, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &AppearanceWidget::updateFontFamily);
     connect(ui->fontFamily, QOverload<int>::of(&QComboBox::currentIndexChanged), [this]() { Q_EMIT appearanceChanged(); });
-    connect(ui->fontFamily, QOverload<int>::of(&QComboBox::currentIndexChanged), this, &AppearanceWidget::updateMoneyPreview);
 
     connect(ui->fontScaleSlider, &QSlider::sliderReleased, [this]() { Q_EMIT appearanceChanged(); });
     connect(ui->fontScaleSlider, &QSlider::valueChanged, this, &AppearanceWidget::updateFontScale);
 
     connect(ui->fontWeightBoldSlider, &QSlider::sliderReleased, [this]() { Q_EMIT appearanceChanged(); });
     connect(ui->fontWeightBoldSlider, &QSlider::valueChanged, [this](auto nValue) { updateFontWeightBold(nValue); });
-    connect(ui->fontWeightBoldSlider, &QSlider::valueChanged, this, &AppearanceWidget::updateMoneyPreview);
 
     connect(ui->fontWeightNormalSlider, &QSlider::sliderReleased, [this]() { Q_EMIT appearanceChanged(); });
     connect(ui->fontWeightNormalSlider, &QSlider::valueChanged, [this](auto nValue) { updateFontWeightNormal(nValue); });
@@ -273,22 +268,6 @@ void AppearanceWidget::updateFontWeightBold(int nValue, bool fForce)
     GUIUtil::updateFonts();
 }
 
-void AppearanceWidget::updateMoneyPreview()
-{
-    QVariant item_data = ui->moneyFont->currentData();
-    if (!item_data.canConvert<OptionsModel::FontChoice>()) {
-        return;
-    }
-    const auto fc = item_data.value<OptionsModel::FontChoice>();
-    if (!std::holds_alternative<OptionsModel::FontChoiceAbstract>(fc)) {
-        return;
-    }
-    if (std::get<OptionsModel::FontChoiceAbstract>(fc) != OptionsModel::FontChoiceAbstract::ApplicationFont) {
-        return;
-    }
-    ui->moneyFont_preview->setFont(GUIUtil::getFontBold());
-}
-
 void AppearanceWidget::updateMoneyFont(int index)
 {
     if (!model) {

src/qt/appearancewidget.h

@@ -41,7 +41,6 @@ private Q_SLOTS:
     void updateFontScale(int nScale);
     void updateFontWeightNormal(int nValue, bool fForce = false);
     void updateFontWeightBold(int nValue, bool fForce = false);
-    void updateMoneyPreview();
     void updateMoneyFont(int index);
 
 private:

src/qt/forms/appearancewidget.ui

@@ -505,13 +505,18 @@
       </spacer>
      </item>
      <item>
-      <widget class="QComboBox" name="moneyFont"/>
-     </item>
-     <item>
-      <widget class="QLabel" name="moneyFont_preview">
-       <property name="text">
-        <string notr="true">111.11111111 DASH
-909.09090909 DASH</string>
+      <widget class="QComboBox" name="moneyFont">
+       <property name="minimumSize">
+        <size>
+         <width>282</width>
+         <height>0</height>
+        </size>
+       </property>
+       <property name="maximumSize">
+        <size>
+         <width>282</width>
+         <height>16777215</height>
+        </size>
        </property>
       </widget>
      </item>

src/qt/guiutil_font.cpp

@@ -94,9 +94,8 @@ constexpr std::array<std::string_view, 18> vecIgnoreClasses{
 };
 
 //! List of Qt objects to ignore when applying fonts
-constexpr std::array<std::string_view, 2> vecIgnoreObjects{
+constexpr std::array<std::string_view, 1> vecIgnoreObjects{
     "messagesWidget",
-    "moneyFont_preview",
 };
 
 //! Weights considered when testing for weights supported by a font

src/qt/optionsmodel.cpp

@@ -527,21 +527,20 @@ QFont OptionsModel::getFontForChoice(const FontChoice& fc)
     if (std::holds_alternative<FontChoiceAbstract>(fc)) {
         switch (std::get<FontChoiceAbstract>(fc)) {
         case FontChoiceAbstract::ApplicationFont:
-            f = GUIUtil::getFontBold();
+            f.setFamily(GUIUtil::g_font_registry.GetFont());
             break;
         case FontChoiceAbstract::EmbeddedFont:
             f = GUIUtil::fixedPitchFont(true);
-            f.setWeight(QFont::Bold);
             break;
         case FontChoiceAbstract::BestSystemFont:
             f = GUIUtil::fixedPitchFont(false);
-            f.setWeight(QFont::Bold);
             break;
         }
     } else {
         f = std::get<QFont>(fc);
     }
-    f.setPointSize(10);
+    // Note: Only the font family is actually used by callers.
+    // Weight and size are overridden in setMonospacedFont().
     return f;
 }