Skip to content

Commit af18062

Browse files
Add python->SQL handling for pyarrow strings, test python 3.9 in upstream import testing (#1206)
* Resolve upstream Dask failures * Fix typo * Override pyarrow string default in sql.yaml * Move pyarrow string override to conftest.py --------- Co-authored-by: Ayush Dattagupta <[email protected]>
1 parent 6623597 commit af18062

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

.github/workflows/test-upstream.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,9 @@ jobs:
110110
with:
111111
miniforge-variant: Mambaforge
112112
use-mamba: true
113-
python-version: "3.8"
113+
# TODO: drop support for python 3.8, add support for python 3.11
114+
# https://github.com/dask-contrib/dask-sql/pull/1143
115+
python-version: "3.9"
114116
channel-priority: strict
115117
- name: Install Protoc
116118
uses: arduino/setup-protoc@v1

.github/workflows/test.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,9 @@ jobs:
107107
with:
108108
miniforge-variant: Mambaforge
109109
use-mamba: true
110-
python-version: "3.8"
110+
# TODO: drop support for python 3.8, add support for python 3.11
111+
# https://github.com/dask-contrib/dask-sql/pull/1143
112+
python-version: ${{ needs.detect-ci-trigger.outputs.triggered == 'true' && '3.9' || '3.8' }}
111113
channel-priority: strict
112114
- name: Install Protoc
113115
uses: arduino/setup-protoc@v1

conftest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ def pytest_addoption(parser):
1212

1313

1414
def pytest_runtest_setup(item):
15+
# TODO: explore adding support for pyarrow string columns
16+
dask.config.set({"dataframe.convert-string": False})
1517
if "gpu" in item.keywords:
1618
if not item.config.getoption("--rungpu"):
1719
pytest.skip("need --rungpu option to run")

0 commit comments

Comments
 (0)