Skip to content

Commit c8a3234

Browse files
authored
Refactor independent cluster configs, pin pandas<2 in cluster environments (#1120)
* Pin independent cluster pandas to <2 * Refactor cluster config files to make environments a little more readable
1 parent 223ba52 commit c8a3234

File tree

6 files changed

+40
-33
lines changed

6 files changed

+40
-33
lines changed

Diff for: .github/cluster-upstream.yml

-23
This file was deleted.

Diff for: .github/workflows/test-upstream.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,9 @@ jobs:
129129
- name: run a dask cluster
130130
run: |
131131
if [[ $which_upstream == "Dask" ]]; then
132-
docker-compose -f .github/cluster-upstream.yml up -d
132+
docker-compose -f continuous_integration/cluster/upstream.yml up -d
133133
else
134-
docker-compose -f .github/cluster.yml up -d
134+
docker-compose -f continuous_integration/cluster/stable.yml up -d
135135
fi
136136
137137
# periodically ping logs until a connection has been established; assume failure after 2 minutes

Diff for: .github/workflows/test.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,9 @@ jobs:
125125
UPSTREAM: ${{ needs.detect-ci-trigger.outputs.triggered }}
126126
run: |
127127
if [[ $UPSTREAM == "true" ]]; then
128-
docker-compose -f .github/cluster-upstream.yml up -d
128+
docker-compose -f continuous_integration/cluster/upstream.yml up -d
129129
else
130-
docker-compose -f .github/cluster.yml up -d
130+
docker-compose -f continuous_integration/cluster/stable.yml up -d
131131
fi
132132
133133
# periodically ping logs until a connection has been established; assume failure after 2 minutes

Diff for: continuous_integration/cluster/environment.yml

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
name: base
2+
channels:
3+
- conda-forge
4+
- nodefaults
5+
dependencies:
6+
# dask serialization needs core libraries to be consistent on client/cluster
7+
- pandas>=1.4.0,<2

Diff for: .github/cluster.yml renamed to continuous_integration/cluster/stable.yml

+5-6
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,19 @@ services:
44
dask-scheduler:
55
container_name: dask-scheduler
66
image: daskdev/dask:dev-py3.9
7-
command: dask-scheduler
7+
command: dask scheduler
88
ports:
99
- "8786:8786"
1010
environment:
1111
USE_MAMBA: "true"
12-
# p2p shuffling requires pyarrow>=7.0.0
13-
EXTRA_CONDA_PACKAGES: "pyarrow>=7.0.0"
12+
volumes:
13+
- ./environment.yml:/opt/app/environment.yml
1414
dask-worker:
1515
container_name: dask-worker
1616
image: daskdev/dask:dev-py3.9
17-
command: dask-worker dask-scheduler:8786
17+
command: dask worker dask-scheduler:8786
1818
environment:
1919
USE_MAMBA: "true"
20-
# TODO: remove pandas constraint once Dask images are updated
21-
EXTRA_CONDA_PACKAGES: "cloudpickle>=2.1.0 pyarrow>=6.0.1 libstdcxx-ng>=12.1.0 pandas>=1.5.0"
2220
volumes:
21+
- ./environment.yml:/opt/app/environment.yml
2322
- /tmp:/tmp

Diff for: continuous_integration/cluster/upstream.yml

+24
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# Docker-compose setup used during tests
2+
version: '3'
3+
services:
4+
dask-scheduler:
5+
container_name: dask-scheduler
6+
image: daskdev/dask:dev-py3.9
7+
command: dask scheduler
8+
ports:
9+
- "8786:8786"
10+
environment:
11+
USE_MAMBA: "true"
12+
EXTRA_CONDA_PACKAGES: "dask/label/dev::dask"
13+
volumes:
14+
- ./environment.yml:/opt/app/environment.yml
15+
dask-worker:
16+
container_name: dask-worker
17+
image: daskdev/dask:dev-py3.9
18+
command: dask worker dask-scheduler:8786
19+
environment:
20+
USE_MAMBA: "true"
21+
EXTRA_CONDA_PACKAGES: "dask/label/dev::dask"
22+
volumes:
23+
- ./environment.yml:/opt/app/environment.yml
24+
- /tmp:/tmp

0 commit comments

Comments
 (0)