Remove unused lsf_version function for Python 3.12 and fix never awaited error for LSFCluster (#646)

* Remove unused lsf_version function for Python 3.12

#644

* Fix _call never awaited

* Fix linting

---------

Co-authored-by: Jacob Tomlinson <[email protected]>

Author: tcztzy

conftest.py

@@ -70,21 +70,6 @@ def pytest_runtest_setup(item):
             item.add_marker(pytest.mark.xfail(reason=xfail[env]))
 
 
-@pytest.fixture(autouse=True)
-def mock_lsf_version(monkeypatch, request):
-    # Monkey-patch lsf_version() UNLESS the 'lsf' environment is selected.
-    # In that case, the real lsf_version() function should work.
-    markers = list(request.node.iter_markers())
-    if any("lsf" in marker.args for marker in markers):
-        return
-
-    try:
-        dask_jobqueue.lsf.lsf_version()
-    except OSError:
-        # Provide a fake implementation of lsf_version()
-        monkeypatch.setattr(dask_jobqueue.lsf, "lsf_version", lambda: "10")
-
-
 all_envs = {
     None: LocalCluster,
     "pbs": PBSCluster,

dask_jobqueue/lsf.py

@@ -1,11 +1,6 @@
-from distutils.version import LooseVersion
-
 import logging
 import math
 import os
-import re
-import subprocess
-import toolz
 
 import dask
 
@@ -113,7 +108,7 @@ def __init__(
     async def _submit_job(self, script_filename):
         if self.use_stdin:
             piped_cmd = [self.submit_command + "< " + script_filename + " 2> /dev/null"]
-            return self._call(piped_cmd, shell=True)
+            return await self._call(piped_cmd)
         else:
             result = await super()._submit_job(script_filename)
             return result
@@ -239,10 +234,3 @@ class LSFCluster(JobQueueCluster):
         job=job_parameters, cluster=cluster_parameters
     )
     job_cls = LSFJob
-
-
-@toolz.memoize
-def lsf_version():
-    out, _ = subprocess.Popen("lsid", stdout=subprocess.PIPE).communicate()
-    version = re.search(r"(\d+\.)+\d+", out.decode()).group()
-    return LooseVersion(version)