From cff343101bf374f343eaeca3b816964d7a2280c3 Mon Sep 17 00:00:00 2001 From: Evgeni Burovski Date: Sun, 23 Mar 2025 18:03:54 +0100 Subject: [PATCH] BUG: fix flaky clip with float32 Testing `clip` converts array elements to builtin types and uses exact equaity. Converting `out` from float32 to 64-bit builtin float incurs floating-point errors, and further exact equality testing fails. So use `math.isclose` instead. closes gh-339 --- .../test_operators_and_elementwise_functions.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/array_api_tests/test_operators_and_elementwise_functions.py b/array_api_tests/test_operators_and_elementwise_functions.py index 1c7d324f..0df00e0e 100644 --- a/array_api_tests/test_operators_and_elementwise_functions.py +++ b/array_api_tests/test_operators_and_elementwise_functions.py @@ -26,6 +26,9 @@ pytestmark = pytest.mark.unvectorized +EPS32 = xp.finfo(xp.float32).eps + + def mock_int_dtype(n: int, dtype: DataType) -> int: """Returns equivalent of `n` that mocks `dtype` behaviour.""" nbits = dh.dtype_nbits[dtype] @@ -1093,7 +1096,13 @@ def refimpl(_x, _min, _max): f"x[{x_idx}]={x_val}, min[{min_idx}]={min_val}, max[{max_idx}]={max_val}" ) else: - assert out_val == expected, ( + if out.dtype == xp.float32: + # conversion to builtin float is prone to roundoff errors + close_enough = math.isclose(out_val, expected, rel_tol=EPS32) + else: + close_enough = out_val == expected + + assert close_enough, ( f"out[{o_idx}]={out[o_idx]} but should be {expected} [clip()]\n" f"x[{x_idx}]={x_val}, min[{min_idx}]={min_val}, max[{max_idx}]={max_val}" )