Skip to content

Remove recommendation of no other public names in namespace #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucascolley opened this issue Apr 17, 2025 · 1 comment · May be fixed by #931
Open

Remove recommendation of no other public names in namespace #928

lucascolley opened this issue Apr 17, 2025 · 1 comment · May be fixed by #931
Assignees

Comments

@lucascolley
Copy link
Member

lucascolley commented Apr 17, 2025

The __array_namespace__ docs say

It may contain other public names as well, but it is recommended to only include those names that are part of the specification.

Is this something we still want to recommend? Or is this a historical artefact from the times of numpy.array_api?

@rgommers
Copy link
Member

Good catch - that's almost certainly a historical artifact. It may still be a reasonable idea for a new library written from scratch that wants to limits its scope to an array object and fundamental operations on/with it, but it certainly doesn't apply to NumPy, PyTorch et al. So best to just remove it. Want to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants