Skip to content

Commit 950c07d

Browse files
authored
Rename get_column_names to column_names and make property (#254)
* get_column_names -> column_names property * get_column_names -> column_names
1 parent a40a6ad commit 950c07d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Diff for: spec/API_specification/dataframe_api/dataframe_object.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def insert_column(self, column: Column[Any]) -> DataFrame:
199199
.. code-block:: python
200200
201201
new_column = df.get_column_by_name('a') + 1
202-
new_columns_names = ['a_plus_1'] + df.get_column_names()
202+
new_columns_names = ['a_plus_1'] + df.column_names
203203
df = df.insert_column(new_column.rename('a_plus_1'))
204204
df = df.select(new_column_names)
205205
@@ -268,7 +268,8 @@ def rename_columns(self, mapping: Mapping[str, str]) -> DataFrame:
268268
"""
269269
...
270270

271-
def get_column_names(self) -> list[str]:
271+
@property
272+
def column_names(self) -> list[str]:
272273
"""
273274
Get column names.
274275

Diff for: spec/purpose_and_scope.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ def my_dataframe_agnostic_function(df):
291291
mask = df.get_column_by_name('species') != 'setosa'
292292
df = df.filter(mask)
293293

294-
for column_name in df.get_column_names():
294+
for column_name in df.column_names
295295
if column_name == 'species':
296296
continue
297297
new_column = df.get_column_by_name(column_name)

0 commit comments

Comments
 (0)