Skip to content

Commit 5934fd3

Browse files
Move python package version to makefile
1 parent 7dc4e93 commit 5934fd3

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

k8/Makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
all: images
22

3+
PYTHON_PACKAGE_VERSION := 1.1.3
4+
35
BASE_BUILD_TAG := 1.1.3
46
BASE_USE_TAG := 1.1.3
57

@@ -73,6 +75,9 @@ define JQ_DOCKER_BAKE
7375
base: {
7476
context: "images/base",
7577
dockerfile: "Dockerfile",
78+
args: {
79+
PYTHON_PACKAGE_VERSION: "${PYTHON_PACKAGE_VERSION}"
80+
},
7681
tags: [
7782
"${IMAGE}:base-${BASE_BUILD_TAG}"
7883
]

k8/images/base/Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# syntax = docker/dockerfile:1.1.7-experimental
22
FROM python:3.8.4
33

4+
ARG PYTHON_PACKAGE_VERSION
5+
46
RUN --mount=type=cache,target=/root/.cache/pip \
5-
pip install record_api==1.1.3
7+
pip install record_api==${PYTHON_PACKAGE_VERSION}
68

0 commit comments

Comments
 (0)