add more integration tests

Author: hantmac

Diff for: databend_sqlalchemy/__init__.py

@@ -3,5 +3,5 @@
 
 from databend_sqlalchemy.entry_points import validate_entrypoints
 
-VERSION = (0, 2, 1)
+VERSION = (0, 2, 2)
 __version__ = '.'.join(str(x) for x in VERSION)

Diff for: databend_sqlalchemy/databend_dialect.py

@@ -235,6 +235,17 @@ def connect(self, *cargs, **cparams):
         # inherits the docstring from interfaces.Dialect.connect
         return self.dbapi.connect(*cargs, **cparams)
 
+    def create_connect_args(self, url):
+        parameters = dict(url.query)
+        kwargs = {
+            'db_url': 'databend://%s:%s@%s:%d/%s' % (
+                url.username, url.password, url.host, url.port or 8000, url.database),
+        }
+        for k, v in parameters.items():
+            kwargs['db_url'] = kwargs['db_url'] + "?" + k + "=" + v
+
+        return ([], kwargs)
+
     def _get_default_schema_name(self, connection):
         return connection.scalar("select currentDatabase()")
 

Diff for: tests/integration/conftest.py

@@ -44,7 +44,7 @@ def engine(
         username: str, password: str, host_port_name: str, database_name: str
 ) -> Engine:
     return create_engine(
-        f"databend://{username}:{password}@{host_port_name}/{database_name}"
+        f"databend://{username}:{password}@{host_port_name}/{database_name}?secure=false"
     )
 
 
@@ -74,7 +74,7 @@ def setup_test_tables(
     connection.execute(
         text(
             f"""
-        CREATE FACT TABLE IF NOT EXISTS {fact_table_name}
+        CREATE TABLE IF NOT EXISTS {fact_table_name}
         (
             idx INT,
             dummy VARCHAR
@@ -85,7 +85,7 @@ def setup_test_tables(
     connection.execute(
         text(
             f"""
-        CREATE DIMENSION TABLE IF NOT EXISTS {dimension_table_name}
+        CREATE TABLE IF NOT EXISTS {dimension_table_name}
         (
             idx INT,
             dummy VARCHAR

Diff for: tests/integration/test_sqlalchemy_integration.py

@@ -12,11 +12,10 @@ def test_set_params(
             self, username: str, password: str, database_name: str, host_port_name: str
     ):
         engine = create_engine(
-            f"databend://{username}:{password}@{host_port_name}/{database_name}"
+            f"databend://{username}:{password}@{host_port_name}/{database_name}?secure=false"
         )
         connection = engine.connect()
         result = connection.execute(text("SELECT 1"))
-        print(result)
         assert len(result.fetchall()) == 1
         engine.dispose()
 
@@ -30,10 +29,27 @@ def test_data_write(self, connection: Connection, fact_table_name: str):
         assert result.fetchall() == [(1, "some_text")]
         result = connection.execute(text(f"SELECT * FROM {fact_table_name}"))
         assert len(result.fetchall()) == 1
-        # Update not supported
-        with pytest.raises(OperationalError):
-            connection.execute(
-                text(
-                    f"UPDATE {fact_table_name} SET dummy='some_other_text' WHERE idx=1"
-                )
-            )
+
+    def test_databend_types(self, connection: Connection):
+        result = connection.execute(text("SELECT to_date('1896-01-01')"))
+        print(str(date(1896, 1, 1)))
+        assert result.fetchall() == [('1896-01-01',)]
+
+    def test_has_table(
+            self, engine: Engine, connection: Connection, fact_table_name: str
+    ):
+        results = engine.dialect.has_table(connection, fact_table_name)
+        assert results == 1
+
+    def test_get_columns(
+            self, engine: Engine, connection: Connection, fact_table_name: str
+    ):
+        results = engine.dialect.get_columns(connection, fact_table_name)
+        assert len(results) > 0
+        row = results[0]
+        assert isinstance(row, dict)
+        row_keys = list(row.keys())
+        assert row_keys[0] == "name"
+        assert row_keys[1] == "type"
+        assert row_keys[2] == "nullable"
+        assert row_keys[3] == "default"